Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problem with webpack #53

Closed
YannickBochatay opened this issue May 12, 2016 · 2 comments · Fixed by #77
Closed

problem with webpack #53

YannickBochatay opened this issue May 12, 2016 · 2 comments · Fixed by #77
Labels

Comments

@YannickBochatay
Copy link

The npm package doesn't have the same name as the AMD module (ismobilejs versus isMobile).
So when you use webpack, you have to create an alias.
I think it should be fine if you don't give a name to your AMD module (l132) :

define([], global.isMobile = instantiate());

instead of

define('isMobile', [], global.isMobile = instantiate());
@kaimallea
Copy link
Owner

Hey @YannickBochatay, thanks for reporting this! Pull request? 😃

@kaimallea
Copy link
Owner

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants