Skip to content

Commit de8acf7

Browse files
committed
mrdoob#12456 Any worker classname is now allowed. It will be renamed to Parser in compiled worker.
1 parent dee33cf commit de8acf7

File tree

2 files changed

+15
-15
lines changed

2 files changed

+15
-15
lines changed

examples/js/loaders/ImageBitmapLoader.js

+8-13
Original file line numberDiff line numberDiff line change
@@ -62,15 +62,13 @@ var canUseImageBitmapOptions = detectCreateImageBitmap( [
6262
* Self-contained worker for fetching and decoding an image, returning an
6363
* ImageBitmap to the main thread.
6464
*/
65-
var Parser = (function () {
65+
var ImageBitmapWorker = (function () {
6666

67-
function Parser() {
67+
function ImageBitmapWorker() {
6868
this.callbackBuilder = null;
69-
this.callbackProgress = null;
7069
}
7170

72-
/* global self */
73-
Parser.prototype.parse = function ( input, options ) {
71+
ImageBitmapWorker.prototype.parse = function ( input, options ) {
7472
var imageBitmapCreator = ( options === undefined ) ? this.workerScope.createImageBitmap( input ) : this.workerScope.createImageBitmap( input, options );
7573

7674
var scope = this;
@@ -86,8 +84,6 @@ var Parser = (function () {
8684
} ).catch( function ( error ) {
8785

8886
var errorMessage = 'THREE.ImageBitmapWorker: ' + error;
89-
console.error( errorMessage );
90-
9187
scope.callbackBuilder(
9288
{
9389
cmd: 'error',
@@ -98,7 +94,7 @@ var Parser = (function () {
9894
} );
9995
};
10096

101-
return Parser;
97+
return ImageBitmapWorker;
10298
})();
10399

104100
var createAbsolutePath = function ( href ) {
@@ -178,7 +174,7 @@ THREE.ImageBitmapLoader.prototype = {
178174
workerCode += '/**\n';
179175
workerCode += ' * This code was constructed by ImageBitmapLoader buildWorkerCode.\n';
180176
workerCode += ' */\n\n';
181-
workerCode += funcBuildSingelton( 'Parser', 'Parser', Parser );
177+
workerCode += funcBuildSingelton( 'Parser', 'Parser', ImageBitmapWorker );
182178

183179
return workerCode;
184180
};
@@ -210,16 +206,15 @@ THREE.ImageBitmapLoader.prototype = {
210206

211207
return response.blob();
212208

213-
} ).then( function ( arrayBuffer ) {
209+
} ).then( function ( blob ) {
214210

215211
workerSupport.run(
216212
{
217213
data: {
218-
input: arrayBuffer,
214+
input: blob,
219215
options: scope.options
220216
}
221-
},
222-
[ arrayBuffer.buffer ]
217+
}
223218
);
224219

225220
} )

examples/js/loaders/LoaderSupport.js

+7-2
Original file line numberDiff line numberDiff line change
@@ -1080,14 +1080,18 @@ THREE.LoaderSupport.WorkerSupport = (function () {
10801080

10811081
if ( scope.terminateRequested ) {
10821082

1083-
scope.logger.logInfo( 'WorkerSupport: Run is complete. Terminating application on request!' );
1083+
scope.logger.logInfo( 'WorkerSupport [' + workerRunner + ']: Run is complete. Terminating application on request!' );
10841084
scope.terminateWorker();
10851085

10861086
}
10871087
break;
10881088

1089+
case 'error':
1090+
scope.logger.logError( 'WorkerSupport [' + workerRunner + ']: Reported error: ' + payload.msg );
1091+
break;
1092+
10891093
default:
1090-
scope.logger.logError( 'WorkerSupport: Received unknown command: ' + payload.cmd );
1094+
scope.logger.logError( 'WorkerSupport [' + workerRunner + ']: Received unknown command: ' + payload.cmd );
10911095
break;
10921096

10931097
}
@@ -1191,6 +1195,7 @@ THREE.LoaderSupport.WorkerSupport = (function () {
11911195
var buildSingelton = function ( fullName, internalName, object ) {
11921196
var objectString = fullName + ' = (function () {\n\n';
11931197
objectString += '\t' + object.prototype.constructor.toString() + '\n\n';
1198+
objectString = objectString.replace( object.name, internalName );
11941199

11951200
var funcString;
11961201
var objectPart;

0 commit comments

Comments
 (0)