Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving Usability by Implementing serde traits #8

Open
simnalamburt opened this issue Oct 7, 2024 · 0 comments
Open

Improving Usability by Implementing serde traits #8

simnalamburt opened this issue Oct 7, 2024 · 0 comments

Comments

@simnalamburt
Copy link
Contributor

As documented in the Rust API Guidelines, implementing the Serialize and Deserialize traits from the Serde crate is crucial for circ’s interoperability. I suggest that circ also implement Serialize and Deserialize, similar to how Serde implements these traits for std::rc::Rc, std::rc::Weak, std::sync::Arc, and std::sync::Weak. And let’s create a feature gate named "rc", and include it in the default features so that Serde support is enabled by default, while allowing for an opt-out option (just like how Serde has done it).

As with last time, I can slowly work on this implementation myself when I have time, but I’m also okay if the maintainers decide to implement it first.

References
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant