Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneccessary pubs. #12

Open
efenniht opened this issue Aug 1, 2019 · 1 comment
Open

Remove unneccessary pubs. #12

efenniht opened this issue Aug 1, 2019 · 1 comment
Assignees

Comments

@efenniht
Copy link
Collaborator

efenniht commented Aug 1, 2019

많은 fields들이 public 한 상태로 선언되어 있습니다.

  • cpu.rs

    • Interrupts -> api.rs 에서 사용
    • VCpu -> {api, cpu}.rs 에서 사용
    • Cpu -> {api, cpu}.rs 에서 사용
  • vm.rs

    • WaitEntry -> api.rs 에서 사용
    • Mailbox -> {api, vm}.rs 에서 사용
    • Vm -> {api, vm}.rs 에서 사용
    • VmLocked
    • TwoVmLocked
  • mm.rs

    • PageTable
    • STAGE2_INVALIDATE: field는 아니지만...
  • slist.rs

    • List
  • spci.rs

    • SpciMessage, SpciMemoryRegionConstituent, SpciMemoryRegion: api.rs 에서 사용
  • list.rs

    • list_entry

해결 방법:

  • 해당 field에 접근하는 함수를 (필요하다면 쪼개서) 각 field가 속한 모듈의 public 함수로 만들거나
  • 어쩔 수 없다면 getter & setter 따위를 만듭니다.
@efenniht efenniht changed the title 불필요한 pub 제거하기 Remove unneccessary pubs. Aug 1, 2019
@efenniht efenniht self-assigned this Aug 1, 2019
@jeehoonkang
Copy link
Member

WIP: 1ab3461

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants