New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global unsafe functions into safe methods (API) #17

Closed

efenniht opened this issue Aug 10, 2019 · 1 comment

Collaborator

efenniht commented Aug 10, 2019 •

edited

Loading

다른 모듈과 달리 api 는 어떤 자료구조의 method로 바꿀만한 함수가 없습니다. 대신,

next: *mut *mut VCpu 를 인자로 받는 함수들을(주로 api.rs에 있음) (*mut VCpu, i32) 따위를 리턴하도록 바꿉니다. 장기적으로는 Option<&mut VCpu> 또는 Result<&mut VCpu, ApiErr> 타입이 되어야 할 것입니다.
전역 변수 API_POOL_INIT 가 mutable인데, 이것을 어떻게 고치는 게 좋을까요? (일단 mpool_init 부터 확인해보기) 또한 이 변수에 락이 없는데 괜찮은 걸까요?
api_interrupt_enable 과 같은 interrupt에 관련된 함수들을 cpu::Interrupts의 멤버 함수로 옮깁니다.

The text was updated successfully, but these errors were encountered:

This was referenced Aug 10, 2019

Use better types instead of constants and unions #13

Closed

Use rich type systems in api/mm/spci. #18

Merged

efenniht mentioned this issue

Refactor api.rs, using VmState on Vm #27

Merged

efenniht mentioned this issue

Wrap mutable states of VCpu with SpinLock (partially done) #39

Merged

Collaborator Author

efenniht commented Sep 23, 2019

#57 을 끝으로 모두 resolve.

efenniht closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment