wrong show for group algebra

[kalmarek]

current:

julia> Z
1·Permutation{Perm{UInt16}, PermGroup{Perm{UInt16}, Transversal{UInt16, Perm{UInt16}}}} () + 1·Permutation{Perm{UInt16}, PermGroup{Perm{UInt16}, Transversal{UInt16, Perm{UInt16}}}} (1,2,3)

expected/was

julia> Z
1·() + 1·(1,2,3)

@blegat you touched the show at latest.
If everything seems ok here, what are the show methods one need to implement in PermutationGroups and/or AbstractPermutations.jl?

[blegat]

It seems that show is the issue:

julia> G = PermGroup(perm"(1,2,3,4,5,6)", perm"(1,2)")
Permutation group on 2 generators generated by
 (1,2,3,4,5,6)
 (1,2)

julia> g = first(G)
()

julia> show(g)
Perm{UInt16} ()0

julia> show(stdout, MIME"text/plain"(), g)
Perm{UInt16} ()

[kalmarek]

No, I guess the issue is that we're loosing io context somehow on the way:

julia> show(IOContext(stdout), MIME"text/plain"(), s1)
Permutation{Perm{UInt16}, PermGroup{Perm{UInt16}, Transversal{UInt16, Perm{UInt16}}}} (1,2,3)
julia> show(IOContext(stdout, :compact => true), MIME"text/plain"(), s1)
(1,2,3)
julia> show(IOContext(stdout, :compact => true), MIME"text/plain"(), Z)
1·Permutation{Perm{UInt16}, PermGroup{Perm{UInt16}, Transversal{UInt16, Perm{UInt16}}}} () + 1·Permutation{Perm{UInt16}, PermGroup{Perm{UInt16}, Transversal{UInt16, Perm{UInt16}}}} (1,2,3)

[blegat]

This is not what I see

julia> g = collect(G)[3]
(3,4,6)

julia> show(IOContext(stdout, :compact => true), MIME"text/plain"(), g)
Perm{UInt16} (3,4,6)
julia> show(stdout, MIME"text/plain"(), g)
Perm{UInt16} (3,4,6)

[kalmarek]

try with :limit=>true (which is set by repl btw.)
the thing with compact is already on its way in AbstractPermutations ;)

[blegat]

Indeed, now I get the same, now idea how it gets lost though

julia> show(IOContext(stdout, :compact => true, :limit=>true), MIME"text/plain"(), g)
(3,4,6)

Maybe because showable returns false here
https://github.com/JuliaAlgebra/StarAlgebras.jl/blob/f998c9f7782e1f3a2f2616b544a3901ede0ba9dc/src/show.jl#L61-L65

[kalmarek]

hmm, even then it should print just fine:

julia> show(IOContext(stdout, :limit=>true), g)
(1,3,2)0