Skip to content
This repository has been archived by the owner on Jan 8, 2019. It is now read-only.

Only require “required” checks #68

Open
tomek-he-him opened this issue Sep 27, 2016 · 2 comments
Open

Only require “required” checks #68

tomek-he-him opened this issue Sep 27, 2016 · 2 comments

Comments

@tomek-he-him
Copy link

tomek-he-him commented Sep 27, 2016

At the moment we have one required check to roll a release onto master – the circle build. However, dennis determines whether the build has succeeded by the last build that came in, not by the required build.

In our case, the code coverage check comes in last – and that check which is optional. This blocks us from releasing in the tightest of deadlines, when we need to cut corners with testing.

@tomek-he-him tomek-he-him changed the title Require “required” checks Only require “required” checks Sep 27, 2016
@petarkabashki
Copy link

please remove me from the email notifications

@tomek-he-him
Copy link
Author

Hey @petarkabashki, you can only do this yourself 🙂

only_require_ required _checks_ _issue__68_ _lystable_dennis

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants