fix: remove kModal class when closing the popup without timeout

amirch1 · amirch1 · commit 432c8fb4d895 · 2017-11-05T15:20:32.000+02:00
diff --git a/kaltura-ui/src/popup-widget/popup-widget.component.ts b/kaltura-ui/src/popup-widget/popup-widget.component.ts
@@ -184,11 +184,11 @@ export class PopupWidgetComponent implements AfterViewInit, OnDestroy{
 			        this.popup.nativeElement.style.bottom = this.popupHeight!== 'auto' ?  this.popupHeight * -1 +"px" :  "-1000px";
 			        timeout = 300;
 		        }
+		        document.body.classList.remove("kModal");
 		        setTimeout(()=>{
 			        // remove modal
 			        if (this.modal && this._modalOverlay) {
 				        document.body.removeChild(this._modalOverlay);
-				        document.body.classList.remove("kModal");
 				        this._modalOverlay = null;
 			        }
 			        this._statechange.next({state: PopupWidgetStates.Close, context: context, reason: reason}); // use timeout to prevent valueChangeAfterChecked error

Original file line number	Diff line number	Diff line change
`@@ -184,11 +184,11 @@ export class PopupWidgetComponent implements AfterViewInit, OnDestroy{`
`184`	`184`	`this.popup.nativeElement.style.bottom = this.popupHeight!== 'auto' ? this.popupHeight * -1 +"px" : "-1000px";`
`185`	`185`	`timeout = 300;`
`186`	`186`	`}`
	`187`	`+ document.body.classList.remove("kModal");`
`187`	`188`	`setTimeout(()=>{`
`188`	`189`	`// remove modal`
`189`	`190`	`if (this.modal && this._modalOverlay) {`
`190`	`191`	`document.body.removeChild(this._modalOverlay);`
`191`		`- document.body.classList.remove("kModal");`
`192`	`192`	`this._modalOverlay = null;`
`193`	`193`	`}`
`194`	`194`	`this._statechange.next({state: PopupWidgetStates.Close, context: context, reason: reason}); // use timeout to prevent valueChangeAfterChecked error`