Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-12916): share Plugin Keyboard Functionality #19

Merged
merged 7 commits into from
Feb 14, 2023
Merged

fix(FEC-12916): share Plugin Keyboard Functionality #19

merged 7 commits into from
Feb 14, 2023

Conversation

lianbenjamin
Copy link
Contributor

@lianbenjamin lianbenjamin commented Feb 8, 2023 •
edited
Loading

Description of the Changes

related PR- kaltura/playkit-js-ui#727

  • disable/enable start from input according to the checkbox
  • removing onChange handler of start from input; handle the input only when user focus out of the input element.
  • in case the value in the input start time element is longer than video duration- set the startTime to video length.
  • allow toggling the start video at checkbox with space keyboard (in addition to Enter)
  • cover user input cases for start at input element. for example if user sets the start at to "1", format it to "00:01"; if user sets the start at to "67", format it to "01:07" etc.
  • fix readme file

Solves FEC-12916

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

JonathanTGold
JonathanTGold previously approved these changes Feb 8, 2023
View reviewed changes
@lianbenjamin lianbenjamin mentioned this pull request Feb 9, 2023
Merged
5 tasks
@lianbenjamin lianbenjamin merged commit 4dcbb19 into master Feb 14, 2023
@lianbenjamin lianbenjamin deleted the FEC-12916 branch February 14, 2023 13:26
lianbenjamin added a commit to kaltura/playkit-js-ui that referenced this pull request Feb 14, 2023
@lianbenjamin
fix(FEC-12916): share Plugin Keyboard Functionality (#727)
d1ff90b 
### Description of the Changes

add functions to time-format.js to support
kaltura/playkit-js-share#19

Solves FEC-12916

### CheckLists

- [ ] changes have been done against master branch, and PR does not
conflict
- [ ] new unit / functional tests have been added (whenever applicable)
- [ ] test are passing in local environment
- [ ] Travis tests are passing (or test results are not worse than on
master branch :))
- [ ] Docs have been updated
borhandarabi pushed a commit to TasvirChi/playchi-js-ui that referenced this pull request May 15, 2024
fix(FEC-12916): share Plugin Keyboard Functionality (#727)
3a824be 
### Description of the Changes

add functions to time-format.js to support
kaltura/playkit-js-share#19

Solves FEC-12916

### CheckLists

- [ ] changes have been done against master branch, and PR does not
conflict
- [ ] new unit / functional tests have been added (whenever applicable)
- [ ] test are passing in local environment
- [ ] Travis tests are passing (or test results are not worse than on
master branch :))
- [ ] Docs have been updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semarche-kaltura semarche-kaltura semarche-kaltura approved these changes

@SivanA-Kaltura SivanA-Kaltura SivanA-Kaltura approved these changes

@giladna giladna Awaiting requested review from giladna

@JonathanTGold JonathanTGold Awaiting requested review from JonathanTGold

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lianbenjamin @semarche-kaltura @JonathanTGold @SivanA-Kaltura