Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(FEC-13462): handle the playback rate after medialoaded event #733

Merged
merged 1 commit into from
Nov 21, 2023
Merged

feat(FEC-13462): handle the playback rate after medialoaded event #733

merged 1 commit into from
Nov 21, 2023
+15 −5

Conversation

lianbenjamin
Copy link
Contributor

@lianbenjamin lianbenjamin commented Nov 21, 2023 •
edited
Loading

Description of the Changes

  • handle the playbackRate after medialoaded event, in order to overcome race condition, where the playbackRate is being overwritten; the engine is re-initializing the playbackRate after the media is loaded.

Solves FEC-13462

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

Sorry, something went wrong.

@lianbenjamin lianbenjamin merged commit 16a4ffa into master Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MosheMaorKaltura MosheMaorKaltura

@semarche-kaltura semarche-kaltura

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lianbenjamin @MosheMaorKaltura @semarche-kaltura