Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require intl extension as a dependency on this repo #65

Closed
diegosurita opened this issue Jan 30, 2024 · 7 comments
Closed

Require intl extension as a dependency on this repo #65

diegosurita opened this issue Jan 30, 2024 · 7 comments

Comments

@diegosurita
Copy link
Contributor

As I mentioned on PR #64, CakePHP 2 docs don't require intl PHP extension.
I oppened this issue to discuss the possibility to add intl as an requirement on this repo. With intl we can stop hidding strftime warning deprecations.

@kamilwylegala
Copy link
Owner

Hey @diegosurita

Introducing Intl would be a breaking change in the framework. But hey... fork is about support of newest PHP versions. In my project I already use Intl, so from my perspective it's totally fine.

I think we could first put a note to the readme file, that we plan to add Intl requirement and link here to this issue. Devs will have a chance to comment on that. If no concerns from others, I think we could commit the Intl requirement to the code base in few months.

What do you think?

@diegosurita
Copy link
Contributor Author

diegosurita commented Jan 31, 2024

Hey!
Yeah I already use it too.

I think we could first put a note to the readme file, that we plan to add Intl requirement and link here to this issue. Devs will have a chance to comment on that. If no concerns from others, I think we could commit the Intl requirement to the code base in few months.

That sounds perfect!

@diegosurita
Copy link
Contributor Author

diegosurita commented Feb 5, 2024

Ok.
@kamilwylegala do you think we can put a date to do this change and add it on the note? If yes, what date would it be?

@kamilwylegala
Copy link
Owner

I just updated the readme file. Beginning of May 2024 sounds OK? We will have 3 months to gather any feedback here. If no objections from others, let's just start rolling this out 🙌

@diegosurita
Copy link
Contributor Author

Yeah that sounds perfect 🙌🏼

@kamilwylegala
Copy link
Owner

@diegosurita I think it's the time: #69 😊

@diegosurita
Copy link
Contributor Author

Hey! I left a comment on you PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants