Fix color toHexa() #4579
Merged
Fix color toHexa() #4579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@asturur did you see this one? Currently |
|
i saw it, but between wekeend and christmas i did not have time to check it |
asturur
reviewed
Dec 26, 2017
src/color.class.js
Outdated
| @@ -192,7 +192,7 @@ | |||
| var source = this.getSource(), a; | |||
|
|
|||
| a = source[3] * 255; | |||
| a = a.toString(16); | |||
There was a problem hiding this comment.
can't we use math.Round on source[3] * 255 instead of using a split string?
|
@asturur Great idea on rounding! Updated Sorry if I rushed you, take your time. Hope you had a good Christmas! |
thiagocunha
pushed a commit
to thiagocunha/fabric.js
that referenced
this pull request
Nov 18, 2019
* Failing Color.toHexa() test * fix color toHexa() to not give decimals * fix hexa test due to rounding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to strip out the decimals.