Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display the correct answer on options challenges #1481

Merged
merged 2 commits into from
Jul 30, 2021

Conversation

zmbc
Copy link
Contributor

@zmbc zmbc commented Jul 27, 2021

Brings the options challenges in line with other challenge types by giving the user feedback on the correct choice when they select an incorrect answer.

Brings the options challenges in line with other challenge types by giving
the user feedback on the correct choice when they select an incorrect
answer.
@vercel
Copy link

vercel bot commented Jul 27, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/kantord/libre-lingo/q1d87VDxeNFxsYxnaig2WdA7eyXS
✅ Preview: https://libre-lingo-git-fork-zmbc-options-correct-answer-kantord.vercel.app

@kantord
Copy link
Owner

kantord commented Jul 28, 2021

Hi @zmbc thank you for your contribution!

It would be nice to include this feature in tests. We're using Cypress with Gherkin feature files.

Take a loot at this line for the short input challenges:

And I read "Correct answer: perro"

Can you please extend this file in order to cover this feature? https://github.com/kantord/LibreLingo/blob/main/apps/web/cypress/integration/optionSelection.feature

@sonarcloud
Copy link

sonarcloud bot commented Jul 29, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@zmbc zmbc changed the title Display the correct answer on options challenges feat: Display the correct answer on options challenges Jul 30, 2021
@zmbc zmbc changed the title feat: Display the correct answer on options challenges feat: display the correct answer on options challenges Jul 30, 2021
@kantord
Copy link
Owner

kantord commented Jul 30, 2021

Thanks @zmbc !!! 🎉 💯

@kantord kantord merged commit 2812718 into kantord:main Jul 30, 2021
@kantord
Copy link
Owner

kantord commented Jul 30, 2021

🎉 This PR is included in version @librelingo/web-v1.19.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants