Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not display multiple of the same option in options challenges #1482

Merged
merged 3 commits into from
Jul 30, 2021
Merged

fix: do not display multiple of the same option in options challenges #1482

merged 3 commits into from
Jul 30, 2021

Conversation

zmbc
Copy link
Contributor

@zmbc zmbc commented Jul 27, 2021 •
edited
Loading

Prevents the user from seeing multiple copies of the same option in an options challenge.

@vercel
Copy link

vercel bot commented Jul 27, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/kantord/libre-lingo/AeWRN7TWp1kxuQthGXs5p3aLqJwh
✅ Preview: https://libre-lingo-git-fork-zmbc-dedupe-options-choices-kantord.vercel.app

kantord
kantord requested changes Jul 28, 2021
View reviewed changes
Copy link
Owner

@kantord kantord left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @zmbc, thanks for the contribution.

Looks like the eslint is failing: https://kantord.semaphoreci.com/jobs/586e351b-ca09-4c64-b629-40aaaf7b4b4d

Also, it looks like the Cypress tests might need some updating: https://kantord.semaphoreci.com/jobs/48cf3499-c5b0-419b-ac0d-3e0420668743

(Or maybe your change introduces some unintended side-effect?)

@sonarcloud
Copy link

sonarcloud bot commented Jul 30, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@zmbc
Copy link
Contributor Author

zmbc commented Jul 30, 2021

@kantord Both issues should be resolved now.

By the way, this PR doesn't totally fix the problem, because it could still happen that an option is given that matches an alternative translation of the phrase/word. However, this info isn't even exported in the JSON yet so I have chosen not to tackle that here. Perhaps it makes sense to create an open issue to track this?

@zmbc zmbc changed the title fix: Do not display multiple of the same option in options challenges fix: do not display multiple of the same option in options challenges Jul 30, 2021
@kantord kantord merged commit dbfad35 into kantord:main Jul 30, 2021
@kantord
Copy link
Owner

kantord commented Jul 30, 2021

Thank you @zmbc ! 🏅

@kantord
Copy link
Owner

kantord commented Jul 30, 2021

🎉 This PR is included in version @librelingo/web-v1.19.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kantord kantord kantord requested changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zmbc @kantord