[Bug][Benchmark] Fix duplicate req in oversampling (vllm-project#26140)

Signed-off-by: Ekagra Ranjan <3116519+ekagra-ranjan@users.noreply.github.com>
Co-authored-by: Roger Wang <hey@rogerw.io>
Signed-off-by: Karan Goel <3261985+karan@users.noreply.github.com>

Author: 2 people

vllm/benchmarks/datasets.py

@@ -235,16 +235,22 @@ def maybe_oversample_requests(
 
         if len(requests) < num_requests:
             random.seed(self.random_seed)
-            additional = deepcopy(
-                random.choices(requests, k=num_requests - len(requests))
-            )
-            for i in range(len(additional)):
-                req = additional[i]
+            needed = num_requests - len(requests)
+            additional = []
+            for i in range(needed):
+                req = deepcopy(random.choice(requests))
                 req.request_id = request_id_prefix + str(len(requests) + i)
+                additional.append(req)
             requests.extend(additional)
             logger.info("Oversampled requests to reach %d total samples.",
                         num_requests)
 
+        ids = [req.request_id for req in requests]
+        if len(ids) != len(set(ids)):
+            raise ValueError("Duplicate request_id found in the sampled "
+                             "requests. Please ensure that each request_id "
+                             "is unique.")
+
 
 # -----------------------------------------------------------------------------
 # Utility Functions and Global Caches