Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MS Internal] Alerts - Change color-coding #135

Closed
karelz opened this issue Apr 10, 2017 · 6 comments
Closed

[MS Internal] Alerts - Change color-coding #135

karelz opened this issue Apr 10, 2017 · 6 comments
Labels
enhancement P2

Comments

@karelz
Copy link
Owner

karelz commented Apr 10, 2017 •
edited
Loading

Current colors: https://jsfiddle.net/ww467dry/

@krwq can you please propose your changes in HTML sample?

<html>
    <head>
        <style>
            table {
                /* border-collapse: collapse; */
                border: 1px solid black;
            }
            table td {
                border: 1px solid black;
            }
            table th {
                border: 1px solid black;
            }
            div.labels {
                color: #808080;
                font-style: italic;
                margin-left: 1cm;
            }
            tr.new_issue {
                background-color: white;
            }
            tr.new_pr {
                background-color: #e0e0e0; /* light grey */
            }
            tr.gone_issue {
                background-color: #fff0f0; /* light red */
            }
            tr.gone_pr {
                background-color: #ffd0d0; /* darker red */
            }
            span.moved_area {
                color: black;
                font-style: normal;
                /*font-weight: bold;*/
            }
        </style>
    </head>
<body>
<table>
  <tr>
    <th>Status</th>
    <th>Issue #</th>
    <th>Title</th>
    <th>Assigned To</th>
    <th>Milestone</th>
  </tr>
  <tr class="new_pr">
    <td>New</td>
    <td>PR #<a href="https://github.com/dotnet/corefx/pull/17507">17507</a></td>
    <td>
      Add more tests for Assembly.LoadFrom
      <br/><div class="labels">Labels: area-System.Runtime, cla-already-signed</div>
    </td>
    <td><a href="https://github.com/rahku">@rahku</a></td>
    <td></td>
  </tr>
  <tr class="new_issue">
    <td>New</td>
    <td>#<a href="https://github.com/dotnet/coreclr/issues/8224">8224</a></td>
    <td>
      Silent crash on Raspberry PI 3
      <br/><div class="labels">Labels: arch-arm32, area-System.Runtime, os-linux</div>
    </td>
    <td></td>
    <td>Future</td>
  </tr>
  <tr class="gone_issue">
    <td>Moved</td>
    <td>#<a href="https://github.com/dotnet/coreclr/issues/7829">7829</a></td>
    <td>
      SafeBuffer.Initialize(numElements, sizeOfEachElement) subject to overflow issues.
      <br/><div class="labels">Labels: <span class="moved_area">area-Interop</span></div>
    </td>
    <td><a href="https://github.com/yizhang82">@yizhang82</a></td>
    <td>2.0.0</td>
  </tr>
  <tr class="gone_pr">
    <td>Closed</td>
    <td>PR #<a href="https://github.com/dotnet/corefx/pull/14763">14763</a></td>
    <td>
      [Wip] Add API and Tests for Collectible Assemblies and AssemblyLoadContext
      <br/><div class="labels">Labels: * NO MERGE *, area-System.Runtime, blocked, cla-already-signed</div>
    </td>
    <td><a href="https://github.com/xoofx">@xoofx</a></td>
    <td></td>
  </tr>
  <tr class="gone_issue">
    <td>Closed</td>
    <td>#<a href="https://github.com/dotnet/coreclr/issues/5716">5716</a></td>
    <td>
      Make search in TimeZoneInfo.GetAdjustmentRuleForTime more efficient
      <br/><div class="labels">Labels: area-System.Runtime, tenet-performance, up-for-grabs</div>
    </td>
    <td></td>
    <td>Future</td>
  </tr>
</table>
</body>
</html>
@krwq
Copy link

krwq commented Apr 10, 2017 •
edited
Loading

It might be too colorful but here is what I can take a look at and know what's happening in one glance:
https://jsfiddle.net/6njfvg6w/

<html>
    <head>
        <style>
            table {
                /* border-collapse: collapse; */
                border: 1px solid black;
            }
            table td {
                border: 1px solid black;
            }
            table th {
                border: 1px solid black;
            }
            div.labels {
                color: #808080;
                font-style: italic;
                margin-left: 1cm;
            }
            tr.new_issue {
                background-color: #ffe0e0;
            }
            tr.new_pr {
                background-color: #ffffd0; /* light grey */
            }
            tr.gone_issue {
                background-color: #e0ffe0; /* light red */
            }
            tr.gone_pr {
                background-color: #e7e7ff; /* darker red */
            }
            span.moved_area {
                color: black;
                font-style: normal;
                /*font-weight: bold;*/
            }
        </style>
    </head>
<body>
<table>
  <tr>
    <th>Status</th>
    <th>Issue #</th>
    <th>Title</th>
    <th>Assigned To</th>
    <th>Milestone</th>
  </tr>
  <tr class="new_pr">
    <td>New</td>
    <td>PR #<a href="https://github.com/dotnet/corefx/pull/17507">17507</a></td>
    <td>
      Add more tests for Assembly.LoadFrom
      <br/><div class="labels">Labels: area-System.Runtime, cla-already-signed</div>
    </td>
    <td><a href="https://github.com/rahku">@rahku</a></td>
    <td></td>
  </tr>
  <tr class="new_issue">
    <td>New</td>
    <td>#<a href="https://github.com/dotnet/coreclr/issues/8224">8224</a></td>
    <td>
      Silent crash on Raspberry PI 3
      <br/><div class="labels">Labels: arch-arm32, area-System.Runtime, os-linux</div>
    </td>
    <td></td>
    <td>Future</td>
  </tr>
  <tr class="gone_issue">
    <td>Moved</td>
    <td>#<a href="https://github.com/dotnet/coreclr/issues/7829">7829</a></td>
    <td>
      SafeBuffer.Initialize(numElements, sizeOfEachElement) subject to overflow issues.
      <br/><div class="labels">Labels: <span class="moved_area">area-Interop</span></div>
    </td>
    <td><a href="https://github.com/yizhang82">@yizhang82</a></td>
    <td>2.0.0</td>
  </tr>
  <tr class="gone_pr">
    <td>Closed</td>
    <td>PR #<a href="https://github.com/dotnet/corefx/pull/14763">14763</a></td>
    <td>
      [Wip] Add API and Tests for Collectible Assemblies and AssemblyLoadContext
      <br/><div class="labels">Labels: * NO MERGE *, area-System.Runtime, blocked, cla-already-signed</div>
    </td>
    <td><a href="https://github.com/xoofx">@xoofx</a></td>
    <td></td>
  </tr>
  <tr class="gone_issue">
    <td>Closed</td>
    <td>#<a href="https://github.com/dotnet/coreclr/issues/5716">5716</a></td>
    <td>
      Make search in TimeZoneInfo.GetAdjustmentRuleForTime more efficient
      <br/><div class="labels">Labels: area-System.Runtime, tenet-performance, up-for-grabs</div>
    </td>
    <td></td>
    <td>Future</td>
  </tr>
</table>
</body>
</html>

@karelz
Copy link
Owner Author

karelz commented Apr 10, 2017

I don't see any difference from the original in your HTML. Did you pasted wrong URL & HTML content?

BTW: Cool HTML-rendering site, thanks!

@krwq
Copy link

krwq commented Apr 10, 2017 •
edited
Loading

@karelz you're right, something went wrong and didn't save it, fortunately my local draft was saved. I've updated in-line

PS. do empty line after <details> so html is not broken

@danmoseley
Copy link

Suggest you fix font also? eg https://jsfiddle.net/ye6qqtwk/4/

@karelz
Copy link
Owner Author

karelz commented Apr 11, 2017 •
edited
Loading

I changed the color-coding yesterday based on the 7:0 votes above. If someone wants further adjustments, please reply to this issue, or file a new issue.

Regarding font: I was intentionally relying on Outlook defaults (same email client default font is used by GitHub email notifications).
I am happy to experiment with the email template, change the font and put there footnote how to vote against the change (better ask for forgiveness than for permission).
Feel free to beat me to it: CoreFxTools\src\apps\GitHubIssuesTracking\DownloadServer\Config\report_template.html (karelz/GitHubIssuesTracking branch).

@karelz
Copy link
Owner Author

karelz commented Apr 11, 2017

Changes made. If there is feedback on the new fonts, please reply.

@karelz karelz closed this as completed Apr 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement P2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@krwq @karelz @danmoseley