Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cocktails I can make should be bar cocktails + shelf cocktails #368

Open
2 tasks done
dphildebrandt opened this issue Nov 25, 2024 · 1 comment
Open
2 tasks done
Assignees
Labels
feat New feature or request

Comments

@dphildebrandt
Copy link

dphildebrandt commented Nov 25, 2024

Checklist

  • I have checked that this feature is not already requested
  • I have checked that this feature does not already exist in the project

Is your feature request related to a problem? Please describe.
If all your ingredients are in the bar shelf, then your 'cocktails i can make' is 0, and you get recommendations for things like

image

Which seems incorrect.

Describe the solution you'd like
Wouldn't it be better for it to be the combined total of your bar cocktails plus cocktails you can make with the ingredients from your shelf?

Additional context
If bar cocktails total is 5, and the (current version) of cocktails I can make is 2, then the suggested new cocktails I can make would actually be 7.

@dphildebrandt dphildebrandt added the feat New feature or request label Nov 25, 2024
@karlomikus
Copy link
Owner

Hi,
This has a fix on dev branch of salt-rim. Currently it's looking at the bar shelf but combining the shelf inventories is probably a good idea.
Thanks!

@karlomikus karlomikus self-assigned this Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants