-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
afterAll support is not released. #188
Comments
Is anyone looking at this? |
I'm not sure if this is the correct place to post - But with this change (although perhaps before as well) And a recent update to Karma described as " Propagate errors thrown in afterAll blocks (f3fa264), closes [#161](https://git hub.com//issues/161)". I am wondering if the collected and propagated error results in a second call to onBrowserComplete() that occurs after onRunComplete() has been called? |
I have noticed an issue with that solution it can obscure errors in such way you don't have any idea where it was thrown: |
We are seeing the same issue with error propagation in our tests as @Xesenix in the latest version (v2.0.1), which, I'm sure you can appreciate makes it extremely difficult to fix failing tests. |
@maksimr / @TheModMaker Any chance you guys could take a look as it seems to relate to a commit that you worked on together? |
I started to open a bug and PR to support error reporting in afterAll functions. But as I looked for how to add a test for this I discovered there already was a test, and the feature is already implemented in PR #162 in March. But there feature never made it into a release.
The last release seems to be v1.1.0 eight months ago.
The text was updated successfully, but these errors were encountered: