fix(deps): Upgrade connect 3.

This means dropping support for node 0.8. Fixes part of #1410
karma-runner · Jun 4, 2015 · b490985 · shanear · Oct 16, 2015 · dignifiedquire
1 parent d5dac1f
commit b490985
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 10 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -3,7 +3,6 @@ node_js:
   - "iojs"
   - "0.12"
   - "0.10"
-  - "0.8"
 
 env:
   global:

diff --git a/lib/middleware/common.js b/lib/middleware/common.js
@@ -83,7 +83,7 @@ var setNoCacheHeaders = function(response) {
 
 
 var setHeavyCacheHeaders = function(response) {
-  response.setHeader('Cache-Control', ['public', 'max-age=31536000']);
+  response.setHeader('Cache-Control', 'public, max-age=31536000');
 };
 
 

diff --git a/lib/middleware/runner.js b/lib/middleware/runner.js
@@ -8,7 +8,7 @@ var path = require('path');
 var helper = require('../helper');
 var log = require('../logger').create();
 var constant = require('../constants');
-var json = require('connect').json();
+var json = require('body-parser').json();
 
 // TODO(vojta): disable when single-run mode
 var createRunnerMiddleware = function(emitter, fileList, capturedBrowsers, reporter, executor,

diff --git a/lib/middleware/source_files.js b/lib/middleware/source_files.js
@@ -4,7 +4,6 @@
 
 var querystring = require('querystring');
 var common = require('./common');
-var pause = require('connect').utils.pause;
 
 
 var findByPath = function(files, path) {
@@ -29,10 +28,7 @@ var createSourceFilesMiddleware = function(filesPromise, serveFile,
         .replace(/^\/absolute/, '')
         .replace(/^\/base/, basePath);
 
-    // Need to pause the request because of proxying, see:
-    // https://groups.google.com/forum/#!topic/q-continuum/xr8znxc_K5E/discussion
-    // TODO(vojta): remove once we don't care about Node 0.8
-    var pausedRequest = pause(request);
+    request.pause();
 
     return filesPromise.then(function(files) {
       // TODO(vojta): change served to be a map rather then an array
@@ -52,7 +48,7 @@ var createSourceFilesMiddleware = function(filesPromise, serveFile,
         next();
       }
 
-      pausedRequest.resume();
+      request.resume();
     });
   };
 };

diff --git a/package.json b/package.json
@@ -194,9 +194,10 @@
     "Jeff Lage <jefflage@me.com>"
   ],
   "dependencies": {
+    "body-parser": "^1.12.4",
     "chokidar": "^1.0.1",
     "colors": "^1.1.0",
-    "connect": "^2.29.2",
+    "connect": "^3.3.5",
     "di": "^0.0.1",
     "expand-braces": "^0.1.1",
     "glob": "^5.0.6",