Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preprocessor failure should cancel (not even start) the execution #550

Closed
hlship opened this issue May 15, 2013 · 5 comments
Closed

Preprocessor failure should cancel (not even start) the execution #550

hlship opened this issue May 15, 2013 · 5 comments
Milestone

Comments

@hlship
Copy link

hlship commented May 15, 2013

When I have errors in my CoffeeScript, I see two problems:

  1. The compilation error is reported without a line number, making it hard to chase down the problem.
INFO [watcher]: Changed file "/Users/hlship/workspaces/annadale/nexus/client/novate-console/src/test/unit/api-services-spec.coffee".
ERROR [preprocess.coffee]: unexpected INDENT
  at /Users/hlship/workspaces/annadale/nexus/client/novate-console/src/test/unit/api-services-spec.coffee
Chrome 26.0 (Mac) LOG: '{\n  "a": 1,\n  "b": 2\n}'
Chrome 26.0 (Mac): Executed 5 of 5 SUCCESS (0.457 secs / 0.068 secs)
  1. The test runner reports success for the tests that did run; however, the test run should be a failure if any sources could not be compiled. In the above, the 5 tests that ran passed, but there were another 7 that never executed due to the compilation error.

This is in Karma 0.8.5.

@vojtajina
Copy link
Contributor

Totally. I created a separate issue for the coffee-preprocessor plugin (to report line numbers).

Any failure during preprocessing should fail the whole run. Probably even not run.

@vojtajina
Copy link
Contributor

Just updated the issue title.

@nc
Copy link

nc commented Dec 4, 2013

+1

@Neppord
Copy link

Neppord commented Jan 22, 2014

1+

@vojtajina
Copy link
Contributor

I fixed this in the coffee preprocessor, but it will be available with Karma 0.12, as this is a breaking change (it's in https://github.com/karma-runner/karma-coffee-preprocessor/tree/preprocessor-error-karma-0.11.14).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants