-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow source maps for non-preprocessed files #893
Comments
Would this be different than this preprocessor? https://github.com/demerzel3/karma-sourcemap-loader |
+1 for allowing source maps for non-preprocessed files. I typically have my editor compile the output javascript files on save, which is typically much faster than running the preprocessor during a karma run as it can do incremental compilation (and a compile server to keep the compiler 'hot' in the JIT runtime). However, I would prefer this stack-trace rewriting to simply work without a sourceMap attribute on the output file pattern. Otherwise I would end up being forced to define ALL my file patterns that way, where currently I have just a list of string files and file patterns in the included files. My alternative: |
:+1 This would really help making TDD/BDD more effective in our build process. |
I put together a Here's a comparison of a stack without/with this plugin. --- stack-without 2015-01-02 15:02:55.000000000 -0700
+++ stack-with 2015-01-02 15:03:12.000000000 -0700
@@ -1,11 +1,11 @@
AssertionError: case 2: expected [ 0, 0.6666666666666666 ] to deeply equal [ 0, 0.5 ]
- at Function.assert.deepEqual (http://localhost:9876/absolute/var/folders/6m/3grlt52x7w3047wy0n6j7dr00000gn/T/2d4c510ad9122153a42db199d1cc8e9553208184.browserify:1848:32)
- at Context.<anonymous> (http://localhost:9876/absolute/var/folders/6m/3grlt52x7w3047wy0n6j7dr00000gn/T/2d4c510ad9122153a42db199d1cc8e9553208184.browserify:6061:14)
+ at Function.assert.deepEqual (node_modules/chai/lib/chai/interface/assert.js:205:1)
+ at Context.<anonymous> (src/scenes/util/geom.test.js:27:1)
at callFn (http://localhost:9876/base/node_modules/mocha/mocha.js:4496:21)
at Test.Runnable.run (http://localhost:9876/base/node_modules/mocha/mocha.js:4489:7)
at Runner.runTest (http://localhost:9876/base/node_modules/mocha/mocha.js:4892:10)
at http://localhost:9876/base/node_modules/mocha/mocha.js:4970:12
at next (http://localhost:9876/base/node_modules/mocha/mocha.js:4817:14)
at http://localhost:9876/base/node_modules/mocha/mocha.js:4827:7
at next (http://localhost:9876/base/node_modules/mocha/mocha.js:4766:23)
at http://localhost:9876/base/node_modules/mocha/mocha.js:4794:5 The plugin simply delegates to the Things are still less than ideal. The debugger doesn't generate clickable links for compiled sources. I'll see if there's a way to address this. Not sure if this will work for other cases, but it is working well for me when using |
Based on discussion in #594.
We could add
sourceMap
attr to file patterns,true
.Also a default preprocessor might check for in-lined source map.
The text was updated successfully, but these errors were encountered: