Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced forced deletion on karmadactl unjoin #4431

Closed
zhzhuang-zju opened this issue Dec 15, 2023 · 2 comments · Fixed by #4451
Closed

Enhanced forced deletion on karmadactl unjoin #4431

zhzhuang-zju opened this issue Dec 15, 2023 · 2 comments · Fixed by #4451
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@zhzhuang-zju
Copy link
Contributor

What would you like to be added:
When karmadactl unjoin, if the cluster object cannot be deleted because the resources of the member clusters cannot be deleted, provide the parameter force to complete the forced deletion of the cluster capability.

Why is this needed:
The following figure shows the flow of execution behind the karmadactl unjoin command. When unjoining a cluster, in order to ensure that the resource can be deleted properly, the finalizers mechanism is used, and the deletion of the resource can only be completed when the task corresponding to the finalizers is completed.
image

This also results in karmadactl unjoin failing all the time if one of the steps doesn't complete properly. In particular, the process involves two clusters: the control cluster as well as the member clusters. Therefore I would like to add the ability to force unjoin to karmadactl unjoin, so that when a delete keeps failing at a certain time, if the ability to force delete is turned on, the finalizers that are blocking the process are deleted so that the process can continue.

@zhzhuang-zju zhzhuang-zju added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 15, 2023
@zhzhuang-zju
Copy link
Contributor Author

The likelihood of persistent failure of deletions across clusters is the greatest, as I am proposing that when the ability to force deletions is currently turned on, only the finalizers of the work are deleted, thus maximising the assurance that the resource is being deleted correctly.

@zhzhuang-zju
Copy link
Contributor Author

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

1 participant