Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kartik gridview issue after "php composer.phar require kartik-v/yii2-krajee-base "dev-master"" #817

Closed
9 tasks
marcantoine9 opened this issue Sep 7, 2018 · 3 comments
Labels

Comments

@marcantoine9
Copy link

marcantoine9 commented Sep 7, 2018

Prerequisites

  • [ X] I have searched for similar issues in both open and closed tickets and cannot find a duplicate.
  • [ X] The issue still exists against the latest master branch of yii2-grid.
  • [ X] This is not an usage question. I confirm having gone through and read the documentation and demos.
  • [ X] This is not a general programming / coding question. (Those should be directed to the webtips Q & A forum).
  • [ X] I have attempted to find the simplest possible steps to reproduce the issue.
  • I have included a failing test as a pull request (Optional).

Steps to reproduce the issue

  1. php composer.phar require kartik-v/yii2-krajee-base "dev-master"
  2. then I load a view with a kartik gridview and I get PHP STRCIT WARNING relating to ($bsVersion)

Expected behavior and actual behavior

When I follow those steps, I see...
screen shot 2018-09-07 at 9 12 39 am

screen shot 2018-09-07 at 9 07 49 am

I was expecting...

to have my view with kartik gridview to load as normal.

Environment

Browsers

  • [X ] Google Chrome
  • Mozilla Firefox
  • Internet Explorer
  • [X ] Safari

Operating System

  • Windows
  • [X ] Mac OS X
  • Linux
  • Mobile

Libraries

  • jQuery version:
  • yii2-grid version:

Isolating the problem

  • This bug happens on the demos page
  • The bug happens consistently across all tested browsers
  • This bug happens when using yii2-grid without other plugins.
@kartik-v
Copy link
Owner

kartik-v commented Sep 7, 2018

This is an issue with your application's composer dependencies and versions of packages you have set for install. You must get the latest versions of yii2-grid and yii2-krajee-base - cross check from the repo version and what version is getting installed on your server.

@kartik-v kartik-v closed this as completed Sep 7, 2018
@Professi
Copy link

I even have this issue when yii2-grid is on version 3.2.0 and yii2-krajee-base is on 1.9.4 with PHP 5.6.

If I comment out line 360 vendor/kartik-v/yii2-grid/src/GridView.php (public $bsVersion) strict warning is gone.

@kartik-v kartik-v reopened this Sep 12, 2018
@kartik-v
Copy link
Owner

Thanks for the report. Will get this fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants