Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Line break" support doesn't work if font doesn't have a newline character #18

Open
curtisgibby opened this issue Oct 7, 2017 · 2 comments
Open

"Line break" support doesn't work if font doesn't have a newline character #18

curtisgibby opened this issue Oct 7, 2017 · 2 comments

Comments

@curtisgibby
Copy link

You could probably just move your additions from 08b308d to after the $letter==10 check to see if it's a newline.
@curtisgibby curtisgibby changed the title "Line break" support doesn't work if font don't have a newline character "Line break" support doesn't work if font doesn't have a newline character Oct 7, 2017
@kartsims
Copy link
Owner

Thanks @curtisgibby for the proposal. Could you please provide a font that doesn't have this character, and if possible send a PR for the code ?

Unfortunately I don't work with PHP anymore but that would help people using the library.

Cheers,

@curtisgibby
Copy link
Author

I was using the Action Jackson font. Here's the .svg:

action_jackson.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@curtisgibby @kartsims