Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Battery extension #149

Closed
2 tasks
Rezenders opened this issue Feb 17, 2024 · 4 comments · Fixed by #155
Closed
2 tasks

Battery extension #149

Rezenders opened this issue Feb 17, 2024 · 4 comments · Fixed by #155

Comments

@Rezenders
Copy link
Collaborator

Rezenders commented Feb 17, 2024

@Rezenders Rezenders changed the title Add argument to launchfile to indicate if battery should be used Battery extension Mar 11, 2024
@QMissinne
Copy link
Contributor

argument added to launchfile as:

  • none (default)
  • battery_constraint (at threshold value, abort mission)

Next step is to implement the functionality of the battery.

@QMissinne
Copy link
Contributor

to implement functionality :
instantiate BatteryMonitor() in inspection_mission. From this use battery_level variable and follow the structure of time_monitor_cb (in time_constrained_mission).

@QMissinne
Copy link
Contributor

Instantiating class is not the right approach.

Instead, subscribe to diagnostics topic and read the battery_level from there. Constraint should remain the same.

@QMissinne
Copy link
Contributor

Current iteration:

  • launch argument still has some issues (not presenting as a possible argument)
  • no condition on whether to use the battery constraint behavior (this should be based on the argument - if nothing is specified then there should be no battery constraint, but if specified in the prompt then the mission should abort at the threshold).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants