-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync RDF::Trine::NamespaceMap and URI::NamespaceMap #90
Comments
It should be possible to do this now, I think I have fixed the issue we talked about in release 0.10. |
Thanks. I'll look at updating RDF::Trine. |
I still don't feel like I'm 100% swapped in on this, but it seems like it might not be as easy as we thought. It doesn't seem to be a drop-in replacement because RDF::Trine code is expecting RDF::Trine::Node::Resource objects back from the namespace expansion, but are instead getting URI objects. I'm not sure where exactly that's happening yet. |
Right, there has to be some compatibility layer that blesses into Resource objects. Perhaps that's something toby can do with Types::URI. |
I don't think so - type constraints are for coercing and validating incoming data. Here we're wanting to change the class of outgoing data. Currently URI::Namespace is doing something like this:
It could instead do something like:
Then Trine could subclass URI::Namespace to make sure that This would probably require some rethinking the URI::Namespace/URI::NamespaceMap classes first. |
I just had a quick look at this, and figured it probably didn't make much sense to do a lot for Trine. |
As soon as URI::NamespaceMap is feature-compatible, RDF::Trine::NamespaceMap should be made an empty subclass of it, with appropriate deprecation warnings in the rest of the code to using the subclass instead of the superclass.
The text was updated successfully, but these errors were encountered: