You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After upgrade from v0.3.1 to v0.4.0, I found kromgo is not be able to access form the nginx.
It seems the default value separated after summer cleaning cuase the issue.
I can default this to be "0.0.0.0" which makes more sense. The issue with the health server though is that you don't particularly want to expose this, so this might stay as localhost. and can be configured if needed.
Hmm, I have a different point of view. As the health server is designed for Prometheus to scrape, and Prometheus is typically an external server to Kromgo. Thus, I think it might make sense for the HealthHost to also default to 0.0.0.0.
After upgrade from
v0.3.1
tov0.4.0
, I found kromgo is not be able to access form the nginx.It seems the default value separated after summer cleaning cuase the issue.
kromgo/cmd/kromgo/init/configuration/configuration.go
Lines 14 to 18 in eb63020
It would be more suitable for a default use case by changing default ServerHost to an empty string "" or "0.0.0.0".
The text was updated successfully, but these errors were encountered: