Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression test? #20

Closed
joeblew99 opened this issue May 21, 2017 · 3 comments
Closed

regression test? #20

joeblew99 opened this issue May 21, 2017 · 3 comments

Comments

@joeblew99
Copy link

would be good to have a test FS and have test that run on it.
The test FS can be created from the test start.

this will make it easy to spoke regressions as the lib grows.

really useful library.

@kashav
Copy link
Owner

kashav commented May 25, 2017

Hey @joeblew99, thanks for the issue!

So I mentioned this in #21, but I'll go into a little more depth here. We actually don't need a virtual filesystem to do this testing, we can just use a testdata directory with all of our files/fixtures. The reason for this is that Go automatically ignores any directory with this name and it reduces a ton of overhead as we don't have to worry about any setup and teardown steps.

I haven't gotten around to adding any of these tests yet, but I agree that they are very important. I'll update this issue as I make progress.

@joeblew99
Copy link
Author

i agree with your approach.

Will leave this open and let you close when your ready.

@kashav
Copy link
Owner

kashav commented Jun 5, 2017

Done in 0b053a6...65350f6, thanks for the issue @joeblew99! 😄

@kashav kashav closed this as completed Jun 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants