Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor reachability service composition #585

Open
coderofstuff opened this issue Oct 28, 2024 · 0 comments
Open

Refactor reachability service composition #585

coderofstuff opened this issue Oct 28, 2024 · 0 comments

Comments

@coderofstuff
Copy link
Collaborator

coderofstuff commented Oct 28, 2024 •
edited
Loading

Refactor relations service to composition-style filtering applicable in layers such as:

filtered_relations = base_relations
    .intersect_with_future_of(root, reachability_service)
    .intersect_with_past_of(selected_tip, reachability_service) // some places in the code below do this step as well

Can be done in a style like UtxoView instances can be composed. Probably better if done in a separate PR

Originally posted by @michaelsutton in #494 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@coderofstuff