You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on May 12, 2021. It is now read-only.
All the rootfs_lib.sh scripts use a repository URL. That could be a required variable in config.sh which would allow rootfs_lib.sh to shrink.
In fact, looking at rootfs_lib.sh, we should move the following to a common scripts/lib.sh that all the rootfs_lib.sh files can source:
check_program()
check_root()
Even generate_dnf() could be parameterised to allow that too to be moved to scripts/lib.sh.
The ideal would be that each repo would only need to specify:
a config.sh
Iffrootfs_lib.sh exists for a distro, it could be used. But the default would be for rootfs.sh to call build_rootfs() from scripts/lib.sh by default (if there is no rootfs_lib.sh` for a particular distro).
The ideal would be to only have a single config file for all distros ("declarative") with all the logic in scripts/lib.sh.
The text was updated successfully, but these errors were encountered:
All the
rootfs_lib.sh
scripts use a repository URL. That could be a required variable inconfig.sh
which would allowrootfs_lib.sh
to shrink.In fact, looking at
rootfs_lib.sh
, we should move the following to a commonscripts/lib.sh
that all therootfs_lib.sh
files can source:check_program()
check_root()
Even
generate_dnf()
could be parameterised to allow that too to be moved toscripts/lib.sh
.The ideal would be that each repo would only need to specify:
config.sh
Iff
rootfs_lib.sh
exists for a distro, it could be used. But the default would be forrootfs.sh
to callbuild_rootfs()
fromscripts/lib.sh by default (if there is no
rootfs_lib.sh` for a particular distro).The ideal would be to only have a single config file for all distros ("declarative") with all the logic in
scripts/lib.sh
.The text was updated successfully, but these errors were encountered: