Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

CI does not catch static check failure on runtime master #2196

Closed
bergwolf opened this issue Dec 25, 2019 · 3 comments
Closed

CI does not catch static check failure on runtime master #2196

bergwolf opened this issue Dec 25, 2019 · 3 comments
Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.

Comments

@bergwolf
Copy link
Member

Description of problem

Running make check in runtime repo master tip, I got following error:

/home/vagrant/workplace/golang/src/github.com/kata-containers/runtime/virtcontainers/utils
cli/kata-check.go:446:20: SA4003: no value of type uintptr is less than 0 (staticcheck)
                if errno != 0 || ret <= 0 {
                                 ^

I'm using v1.15.0 of golangci-lint as required by runtime versions.yaml.

Any reason CI is not catching it?

@bergwolf bergwolf added bug Incorrect behaviour needs-review Needs to be assessed by the team. labels Dec 25, 2019
@bergwolf
Copy link
Member Author

Same is true for make test. CI seems to ignore make test failures as well?

see kata-containers/runtime#2371

@bergwolf
Copy link
Member Author

@grahamwhaley
Copy link
Contributor

Is this understood/fixed now @bergwolf ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.
Projects
None yet
Development

No branches or pull requests

3 participants