New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PluginClient 在请求某些资源时， secret 是可选的，但必须传一个空对象 #315

Open

chengjingtao opened this issue Nov 21, 2022 · 0 comments

Contributor

chengjingtao commented Nov 21, 2022

Expected Behavior

https://github.com/katanomi/pkg/blob/main/plugin/client/gitcontent.go#L40 不需要 secret时，不用传递即可。

Actual Behavior

现在必须在业务方构造一个空的secret.

	// If the secret is not found, set empty object.
	if secret == nil {
		secret = &corev1.Secret{}
	}

https://github.com/katanomi/builds/pull/164/files

Steps to Reproduce the Problem

Additional Info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment