You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We should check explicitly for a true value as a condition to turn ON the flags.
In case if someone will use strings based value "false", "true" eg using dotEnv settings (which does not support boolean values) the addon will gonna interpret "false" as true which is not expected.
We should check explicitly for a
true
value as a condition to turn ON the flags.In case if someone will use strings based value
"false"
,"true"
eg using dotEnv settings (which does not support boolean values) the addon will gonna interpret"false"
astrue
which is not expected.ember-feature-flags/addon/services/features.js
Lines 58 to 61 in 93113e7
As the best solution, we should parse the flag value (in case of string) and look for
Or as a minimum, we should check explicitly if the
value === true
The text was updated successfully, but these errors were encountered: