Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crosswalk compability #426

Closed
MaZZly opened this issue Feb 24, 2015 · 79 comments
Closed

Crosswalk compability #426

MaZZly opened this issue Feb 24, 2015 · 79 comments

Comments

@MaZZly
Copy link

MaZZly commented Feb 24, 2015

With crosswalk it doesn't compile if localnotification plugin is used.

APP/platforms/android/src/de/appplant/cordova/plugin/localnotification/LocalNotification.java:473: error: cannot find symbol
                    webView.evaluateJavascript(js, null);
                           ^
  symbol:   method evaluateJavascript(String,<null>)
  location: variable webView of type CordovaWebView
APP/platforms/android/src/de/appplant/cordova/plugin/localnotification/LocalNotification.java:470: error: cannot find symbol
        webView.post(new Runnable(){
               ^
  symbol:   method post(<anonymous Runnable>)
  location: variable webView of type CordovaWebView
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
2 errors
 FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':compileArmv7DebugJava'.

I can get rid of compilation errors by removing the sendJavascript function in LocalNotification.java:463
and replacing the 2 calls to it (:419 & :454) with webView.sendJavascript(js);

Then it will compile.. Then when calling cancelAll() or scheduledIds() (And maybe others) the app crashes and output is:
[ERROR:runtime_javascript_dialog_manager.cc(69)] Not implemented reached in virtual void xwalk::RuntimeJavaScriptDialogManager::WebContentsDestroyed(content::WebContents*)

Ideas?

@ghost
Copy link

ghost commented Mar 10, 2015

I can confirm this issue too. Any idea?
Btw., MaZZly's workaround works for me also.

@shprink
Copy link

shprink commented Mar 14, 2015

same here!

@marco-broccio
Copy link

Same here.

Temporarily use this. It works for me.

http://plugins.cordova.io/#/package/jp.wizcorp.phonegap.plugin.localnotificationplugin

@DanailMinchev
Copy link

I'm receiving same error in Apache Cordova Android 4.0.0

/home/danail/git/app/platforms/android/src/de/appplant/cordova/plugin/localnotification/LocalNotification.java:495: error: cannot find symbol
                    webView.evaluateJavascript(js, null);
                           ^
  symbol:   method evaluateJavascript(String,<null>)
  location: variable webView of type CordovaWebView
/home/danail/git/app/platforms/android/src/de/appplant/cordova/plugin/localnotification/LocalNotification.java:492: error: cannot find symbol
        webView.post(new Runnable(){
               ^
  symbol:   method post(<anonymous Runnable>)
  location: variable webView of type CordovaWebView
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: /home/danail/git/app/platforms/android/src/org/apache/cordova/file/ContentFilesystem.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
2 errors
 FAILED

According to http://cordova.apache.org/announcements/2015/04/15/cordova-android-4.0.0.html, new Android uses first-class support for Crosswalk

@danielfpedro
Copy link

same here

@danielfpedro
Copy link

Not sure if the issue is about crosswalk or the new cordova release that is building with Gradle instead Ant

@katzer
Copy link
Owner

katzer commented May 2, 2015

local-notification plugin will support Cordova 4 and Crosswalk starting with v0.9

@danielfpedro
Copy link

Can you say when? I'm not trying to rush you, I'm asking because I have a project that is using crosswalk and I'm wating this release

@danjohnso
Copy link

I'm also running into this, any timeline on 0.9?

@keenkiran
Copy link

I am also running into this same issue. When do you think 0.9 will be out please ?

@pnmougel
Copy link

pnmougel commented May 7, 2015

Same problem here, I would like to use this plugin with Crosswalk

@mirkofisic
Copy link

I have the same problem with cordova 5.0.0

1 similar comment
@TedWei
Copy link

TedWei commented May 9, 2015

I have the same problem with cordova 5.0.0

@shuhanxu
Copy link

+1

1 similar comment
@sonnylazuardi
Copy link

+1

@seth100
Copy link

seth100 commented May 10, 2015

+1, same problema with cordova 5.0.0 and android platform version 4.0.0

@hafeyang
Copy link

+1

@mejainankit
Copy link

+1, i also have same issue with cordova 5.0.0 and cordova android platform 4.0.0

@Durss
Copy link

Durss commented May 11, 2015

is it really necessary to say i have the same problem..? :p

EDIT : This branch worked for me :)
https://github.com/DarianLewin/cordova-plugin-local-notifications/tree/issue-535-quick-fix

@mansa-dev
Copy link

+1 Crosswalk on Cordova@5.0

@dwhogg
Copy link

dwhogg commented May 12, 2015

+1

2 similar comments
@martinbrylski
Copy link

+1

@Gaafar
Copy link

Gaafar commented May 15, 2015

+1

@Gaafar
Copy link

Gaafar commented May 15, 2015

Having the same issue without crosswalk

@ag-secret
Copy link

Why this issue was closed?

@ankitbtanna
Copy link

I am having similar issue with phonegap 4.

@bradmartin
Copy link

@danda1man thanks! I'll use the fix then. Big thanks to @canda for the code.

@murilolobato
Copy link

Shouldn't be created a pull request to fix this, and create a new tag in the repository to be used with cordova 5?

@ObjectiveTruth
Copy link

Thank you @canda! for the code snipped. It all works now.

This Should really just be updated in a PR

@kennedymca
Copy link

not working i have a error cannot resolve method in this line webView.evaluateJavascript(js, null)

@behrad
Copy link

behrad commented Jul 6, 2015

+1

3 similar comments
@flavioalves
Copy link

+1

@ants-house
Copy link

+1

@HNygard
Copy link

HNygard commented Jul 16, 2015

+1

@allan-empalmado
Copy link

@canda fix works :)

@conchz
Copy link

conchz commented Aug 3, 2015

+1

3 similar comments
@marcoocram
Copy link

+1

@seth100
Copy link

seth100 commented Aug 5, 2015

+1

@csvan
Copy link

csvan commented Aug 5, 2015

+1

@mblecek
Copy link

mblecek commented Aug 10, 2015

  • 1

@hirogasa
Copy link

hirogasa commented Sep 1, 2015

+1

1 similar comment
@Crashthatch
Copy link

+1

@moshetet
Copy link

moshetet commented Sep 5, 2015

Hi had a compliation error with @canda`s fix due to the method sendJavascript expecting only one argument and not the 2nd null parameter that was still left there.
I've forked it and fixed it. if anyone is interested:
https://github.com/moshetet/cordova-plugin-local-notifications

@nerdfiles
Copy link

@canda's solution +1

@davidarchanjo
Copy link

@lobobobo
Copy link

@canda thank you so much your solution worked for me :)
@sharifbdp thank you too for half solution;)

@donaldinou
Copy link

+1
We need a new release :P

@swswnt
Copy link

swswnt commented Feb 8, 2016

how to end schedule notification after particular time(2 hours)??

@jQrgen
Copy link

jQrgen commented Feb 16, 2016

+1

1 similar comment
@degaray
Copy link

degaray commented Mar 24, 2016

+1

@vancentvan
Copy link

Call native app from a web application and then get this error while tabbing back ....
[ERROR: runtime_javascript_dialog_manager.cc(69) ] Not implemented reached in virtual void xwalk::RuntimeJavaScriptDialogmanager::ResetDialogState(content::WebContents*)

@felixschul
Copy link

@darchanjo I am not surprised that sebasis's plugin compiles, since the relevant lines are just commented out: https://github.com/sebasi/cordova-plugin-local-notifications/blob/master/src/android/LocalNotification.java#L552
I would be surprised if the actual notifications fire through...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests