-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAJOR BUG: test compare doesn't work as expected #57
Comments
Oh wow, I didn't realize it uses 1bit masks. My old method was slow as anything but it's guaranteed to work I guess. We should really test the compare method... |
I implemented a new method, however, I uncovered a super depressing recent bug in Pygame for OS X, which felt like a steel blade to my heart. https://bitbucket.org/pygame/pygame/issues/298/bmp-and-png-images-not-loaded-correctly In summary, I'll open an image, I can test that the color data is wrong, and when I save it it's exactly as I expected when finding the color samplings wrong. Again, if pygame opens an image, the color data is super messed, and you can test such with I'll have to develop on another... operating system... until these issues are resolved. :( |
Okay so this occurs because of the difference in pygame being tested with In summation, pygame bug only in tests, not when pygame actually initialized. |
Is there a way to have an init function that py.test will run before running the tests? |
Test compare doesn't work as expected, which is my error, I should've read closer that
PixelArray.compare
uses 1bit masks, thus if you test a GIF which is two frames of two different solid colors, it may say they're exactly alike.I'll restore the version which @txanatan made.
The text was updated successfully, but these errors were encountered: