Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debuffs on self playing no VFX or SFX #53

Open
EminentEmily opened this issue Nov 30, 2024 · 8 comments
Open

Debuffs on self playing no VFX or SFX #53

EminentEmily opened this issue Nov 30, 2024 · 8 comments

Comments

@EminentEmily
Copy link

As of latest patch no VFX/SFX play when applying debuffs whatsoever; buffs still work as expected.

@Glyceri
Copy link
Collaborator

Glyceri commented Dec 1, 2024

This is somewhat intended. By default it now uses the VFX that belongs with the icon. If you cast the doom icon on yourself it'll now use the doom VFX. However, some icons don't get any VFX. You can use the new custom VFX path setting to apply a VFX in that case.
image

@heschlim
Copy link

heschlim commented Dec 2, 2024

For me, this new "Custom VFX Path" feature doesn't seem to do anything. No matter what I set it to, I see no VFX/SFX playing.

@Glyceri
Copy link
Collaborator

Glyceri commented Dec 2, 2024

Are you getting an error log in /xllog? I've tried to make sure it prints errors when stuff goes wrong.

@heschlim
Copy link

heschlim commented Dec 2, 2024

It's been spamming my /xllog with this error about 20 times a second
07:01:38.944 | ERR | Exception during raise of "Void <InvokeSafely>b__0()" System.NullReferenceException: Object reference not set to an instance of an object. at Moodles.Processors.CommonProcessor.Tick() in D:\a\Moodles\Moodles\Moodles\GameGuiProcessors\CommonProcessor.cs:line 133 at Dalamud.Utility.EventHandlerExtensions.HandleInvoke(Action act) in C:\goatsoft\companysecrets\dalamud\\Utility\EventHandlerExtensions.cs:line 124

@Glyceri
Copy link
Collaborator

Glyceri commented Dec 2, 2024

I think this has to do with something else.... HOOOAAGGHHH. This is probably why it is breaking VFX, ill have a look at it when I'm home😭

@Glyceri
Copy link
Collaborator

Glyceri commented Dec 2, 2024

Tentatively fixed in 1.0.0.34 lmk if it isnt

@EminentEmily
Copy link
Author

Hello! So it seems that custom VFX works great when it comes to playing the VFX/SFX for debuffs. It only seems to not be playing when there's no custom VFX path set for the Moodle. I activated Debug mode and checked the log, and I saw this line which might be relevant? > [12/2/2024 7:29:48 PM -08:00] Path for SHE is empty

@Glyceri
Copy link
Collaborator

Glyceri commented Dec 3, 2024

HMMMM, if the path is empty itll take path that belongs with the icon, sometimes those are empty as well (some icons just don't get a VFX by default in the game :c ). I think ill add a case where if the default path is empty we use the old (moodle 1.0.0.29) vfx path as a backup later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants