-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option for non-zero exit status when deployment is rolled back (rolling deployment) #732
Comments
@karaluh Thank you for the reporting! I agree that behavior is undesirable. When the circuit breaker is invoked, ECS sends events to EventBridge, but ecspresso cannot capture the events without external AWS services (for example, SQS). So, I'm planning to detect the deployment failure by comparing the task definition in the Deployment after the service is stable. |
@karaluh v2.4.0-rc1 released! Please try it. |
Works as expected, thanks a lot! |
Currently, when deploying a service with rolling deployment strategy and the deployment fails and is rolled back, ecspresso exits with a 0 status code. It should exit with a non-zero status code, because the deployment actually failed, or at least provide an option to do so.
The text was updated successfully, but these errors were encountered: