Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option for non-zero exit status when deployment is rolled back (rolling deployment) #732

Open
karaluh opened this issue Jul 30, 2024 · 3 comments

Comments

@karaluh
Copy link

karaluh commented Jul 30, 2024

Currently, when deploying a service with rolling deployment strategy and the deployment fails and is rolled back, ecspresso exits with a 0 status code. It should exit with a non-zero status code, because the deployment actually failed, or at least provide an option to do so.

@fujiwara
Copy link
Contributor

fujiwara commented Aug 1, 2024

@karaluh Thank you for the reporting!

I agree that behavior is undesirable.

When the circuit breaker is invoked, ECS sends events to EventBridge, but ecspresso cannot capture the events without external AWS services (for example, SQS).
https://docs.aws.amazon.com/AmazonECS/latest/developerguide/ecs_service_deployment_events.html

So, I'm planning to detect the deployment failure by comparing the task definition in the Deployment after the service is stable.

@fujiwara
Copy link
Contributor

fujiwara commented Aug 2, 2024

@karaluh v2.4.0-rc1 released! Please try it.
https://github.com/kayac/ecspresso/releases/tag/v2.4.0-rc1

@karaluh
Copy link
Author

karaluh commented Aug 5, 2024

Works as expected, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants