Fix typings in components #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #344 +/- ##
=======================================
Coverage 96.19% 96.19%
=======================================
Files 9 9
Lines 631 631
=======================================
Hits 607 607
Misses 24 24Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typescript typings are incorrect for component options. Typescript expects entire VueI18n object and not just
messages.This does not allow to use "Component based localization" http://kazupon.github.io/vue-i18n/en/component.html
This fix allows to only set
messages,dateTimeFormatsandnumberFormatsas i18n options in vue component.I added failing test case but I cannot find where typings are checked.