Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning for circular reference in linked message #438

Merged
merged 4 commits into from
Oct 13, 2018

Conversation

exoego
Copy link
Collaborator

@exoego exoego commented Oct 13, 2018

Closes #247

If circular reference found in translation process, it will be warned and the re-visited link key @:cicular left as-is in translated message.

Warning log will be
WARN: '[vue-i18n] Circular reference found. "@:message.circular1" is already visited in the chain of message.circular3 <- message.circular2 <- message.circular1'

@codecov-io
Copy link

codecov-io commented Oct 13, 2018

Codecov Report

Merging #438 into dev will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #438      +/-   ##
==========================================
+ Coverage   95.93%   95.95%   +0.01%     
==========================================
  Files           9        9              
  Lines         639      642       +3     
==========================================
+ Hits          613      616       +3     
  Misses         26       26
Impacted Files Coverage Δ
src/index.js 99.59% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acfc458...73e95e6. Read the comment docs.

Copy link
Owner

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR!
Great works! 👍

@kazupon kazupon merged commit 7583485 into kazupon:dev Oct 13, 2018
@exoego exoego deleted the warn-circular-ref branch October 13, 2018 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants