feat(path): Keypath should parse if sub path contains spaces. #533

exoego · 2019-03-13T12:25:40Z

Closes #532 (and its original #502)

I believe "hierarchical key containing space 0x20" like nested.Hello World should be OK, since non-hierarchical key like Hello {0} can contain space.

vue-i18n/test/unit/basic.test.js

Lines 92 to 97 in 70eedb1

    
           it('should return replaced string if available', () => { 
        
             assert.strictEqual( 
        
               i18n.t('Hello {0}', ['kazupon']), 
        
               'Hello kazupon' 
        
             ) 
        
           })

codecov-io · 2019-03-13T12:29:51Z

Codecov Report

Merging #533 into dev will decrease coverage by 0.43%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev     #533      +/-   ##
==========================================
- Coverage   96.63%   96.19%   -0.44%     
==========================================
  Files           9        9              
  Lines         684      684              
==========================================
- Hits          661      658       -3     
- Misses         23       26       +3

Impacted Files	Coverage Δ
src/path.js	`84.25% <ø> (-2.78%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70eedb1...6dd6658. Read the comment docs.

codecov-io · 2019-03-13T12:29:51Z

Codecov Report

Merging #533 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #533   +/-   ##
=======================================
  Coverage   96.63%   96.63%           
=======================================
  Files           9        9           
  Lines         684      684           
=======================================
  Hits          661      661           
  Misses         23       23

Impacted Files	Coverage Δ
src/path.js	`87.03% <ø> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70eedb1...7c7bba5. Read the comment docs.

kazupon

Good job! 👍
Thanks!

@exoego

* ⭐ new(path): Keypath should parse if sub path contains spaces. (kazupon#533) by @exoego * feat(path): Keypath should parse if sub path contains spaces. * feat(path): Added test for whitespaces * 📝 docs(vuepress): pluralization will not work unless you use $tc (kazupon#540) by @lebesnec * ⭐ new(number): i18n-n functional component (kazupon#541) by @bponomarenko

@exoego

closes #531 * docs: add vuepress zh docs config * docs(zh/README.md): Translation README.md file * docs(zh/README.md): Translation installation.md file * docs: Translation introduction.md file * docs: Translation started.md file * docs: 更改称谓 * docs: Translation api/README.md file * style: values type * fix: pluralization -> 多元化 * fix: locale translation * docs: Translation api/formatting file * docs: Translation guide/pluralization.md file * fixed: fix type * docs: All translation completed * Update vuepress/.vuepress/config.js 参照Vue的规范修正译文中的格式 Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * fix: type * fix: 区域设置 -> 语言环境 * style: Modify the format including punctuation and spaces * fix: 修复vuepress config * Update if not ..., check ... -> 如果没有则 Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * Update 主语前置 Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * Update 完善用语 Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * Update 语义更明确 Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * fix: Correct the format to remove extra spaces * update: 提示 -> tip * Update vuepress/zh/api/README.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * 更改主谓 Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * 提高句子的可读性 Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * 提高句子的可读性 Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * Update vuepress/zh/api/README.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * Update vuepress/zh/api/README.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * fix: Fix some keyword errors and various issues * update: Optimize text for readability * Update vuepress/zh/guide/formatting.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * Update vuepress/zh/guide/formatting.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * Update vuepress/zh/guide/formatting.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * Update vuepress/zh/guide/formatting.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * Update vuepress/zh/guide/formatting.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * Update vuepress/zh/guide/formatting.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * Update vuepress/zh/guide/formatting.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * Update vuepress/zh/guide/formatting.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * Update vuepress/zh/guide/formatting.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * Update vuepress/zh/guide/formatting.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * Update vuepress/zh/guide/formatting.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * Update vuepress/zh/guide/hot-reload.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * Update vuepress/zh/guide/interpolation.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * Update vuepress/zh/guide/interpolation.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * Update vuepress/zh/guide/interpolation.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * Update vuepress/zh/guide/interpolation.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * Update vuepress/zh/guide/interpolation.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * Update vuepress/zh/guide/lazy-loading.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * Update vuepress/zh/guide/lazy-loading.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * Update vuepress/zh/guide/lazy-loading.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * Update vuepress/zh/guide/locale.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * Update vuepress/zh/guide/locale.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * Update vuepress/zh/guide/locale.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * Update vuepress/zh/guide/lazy-loading.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * Update vuepress/zh/guide/lazy-loading.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * 区域 -> 语言环境, 消息 -> 信息 * Update vuepress/zh/guide/messages.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * Update vuepress/zh/guide/messages.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * Update vuepress/zh/guide/messages.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * Update vuepress/zh/guide/messages.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * Update vuepress/zh/guide/number.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * fix: Locale Messages -> 语言环境信息 * 同步源仓库到Fock仓库 (#1) * ⭐ new(path): Keypath should parse if sub path contains spaces. (#533) by @exoego * feat(path): Keypath should parse if sub path contains spaces. * feat(path): Added test for whitespaces * 📝 docs(vuepress): pluralization will not work unless you use $tc (#540) by @lebesnec * ⭐ new(number): i18n-n functional component (#541) by @bponomarenko * Revert "同步源仓库到Fock仓库 (#1)" (#2) This reverts commit 8f8a88b. * Update vuepress/zh/guide/pluralization.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * Update vuepress/zh/guide/pluralization.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * Update vuepress/zh/guide/pluralization.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * Update vuepress/zh/guide/sfc.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * Update vuepress/zh/guide/sfc.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * Update vuepress/zh/guide/sfc.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * Update vuepress/zh/guide/sfc.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * Update vuepress/zh/guide/sfc.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * Update vuepress/zh/guide/sfc.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * Update vuepress/zh/guide/sfc.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * Update vuepress/zh/guide/sfc.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * Update vuepress/zh/guide/sfc.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * Update vuepress/zh/guide/sfc.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * Update vuepress/zh/guide/sfc.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * Update vuepress/zh/guide/sfc.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * style: code style * Update vuepress/zh/installation.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * Update vuepress/zh/installation.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * Update vuepress/zh/installation.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * Update vuepress/zh/installation.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * Update vuepress/zh/installation.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * Update vuepress/zh/installation.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * Update vuepress/zh/introduction.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * Update vuepress/zh/introduction.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * Update vuepress/zh/introduction.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * Update vuepress/zh/introduction.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * Update vuepress/zh/started.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * Update vuepress/zh/started.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * Update vuepress/zh/started.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * Update vuepress/zh/started.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * Update vuepress/zh/started.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * Update vuepress/zh/legacy/README.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * Update vuepress/zh/legacy/README.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com> * Update vuepress/zh/legacy/README.md Co-Authored-By: xuhongbo <xuhongbo@outlook.com>

feat(path): Keypath should parse if sub path contains spaces.

6dd6658

exoego mentioned this pull request Mar 13, 2019

can't parse key contain space in sub path correctly #502

Closed

exoego force-pushed the keypath-space branch 2 times, most recently from 31323b6 to dc96d28 Compare March 13, 2019 23:56

feat(path): Added test for whitespaces

7c7bba5

exoego force-pushed the keypath-space branch from dc96d28 to 7c7bba5 Compare March 14, 2019 00:04

kazupon approved these changes Mar 14, 2019

View reviewed changes

kazupon merged commit 640daaf into kazupon:dev Mar 14, 2019

pr-triage bot added the PR: merged label Mar 14, 2019

exoego deleted the keypath-space branch March 14, 2019 08:18

exoego mentioned this pull request Mar 27, 2019

localize the string based messages #530

Closed

tt9133github mentioned this pull request Sep 18, 2019

[Snyk] Upgrade vue-i18n from 8.0.0 to 8.14.0 tt9133github/snyktest#3

Open

snyk-bot mentioned this pull request Oct 26, 2019

[Snyk] Upgrade vue-i18n from 7.8.1 to 8.15.0 ajesse11x/vuetify#5

Open

Roriz mentioned this pull request Nov 6, 2019

v8.10.0 with Breaking changes #736

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(path): Keypath should parse if sub path contains spaces. #533

feat(path): Keypath should parse if sub path contains spaces. #533

exoego commented Mar 13, 2019 •

edited

Loading

codecov-io commented Mar 13, 2019

codecov-io commented Mar 13, 2019 •

edited

Loading

kazupon left a comment

	it('should return replaced string if available', () => {
	assert.strictEqual(
	i18n.t('Hello {0}', ['kazupon']),
	'Hello kazupon'
	)
	})

feat(path): Keypath should parse if sub path contains spaces. #533

feat(path): Keypath should parse if sub path contains spaces. #533

Conversation

exoego commented Mar 13, 2019 • edited Loading

codecov-io commented Mar 13, 2019

Codecov Report

codecov-io commented Mar 13, 2019 • edited Loading

Codecov Report

kazupon left a comment

Choose a reason for hiding this comment

exoego commented Mar 13, 2019 •

edited

Loading

codecov-io commented Mar 13, 2019 •

edited

Loading