Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove app names from file mapping configuration #170

Open
MrCreosote opened this issue Mar 28, 2022 · 1 comment
Open

Remove app names from file mapping configuration #170

MrCreosote opened this issue Mar 28, 2022 · 1 comment

Comments

@MrCreosote
Copy link
Member

Narrative now specifies the app names and so the entries in the staging service are cruft

E.g this dict should no longer be needed: https://github.com/kbase/staging_service/blob/master/staging_service/autodetect/GenerateMappings.py#L32

Note this is a backward incompatible change, so be sure that anyone currently using endpoints that return these names aren't depending on them. I believe this is the case, but double checking is good.

@bio-boris
Copy link
Collaborator

The narrative ignores these as of kbase/narrative#2658 I believe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants