New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SRA reads extraction command is a single string rather than an array of strings #326

Open

MrCreosote opened this issue Jun 21, 2021 · 0 comments

Member

MrCreosote commented Jun 21, 2021

That makes user attacks possible as subprocess can't quote arguments correctly.

kb_uploadmethods/lib/kb_uploadmethods/Utils/ImportSRAUtil.py

Lines 60 to 61 in 86bf252

    
           command = self.SRA_TOOLKIT_PATH + ' --split-3 -T -O ' 
        
           command += tmp_dir + ' ' + scratch_sra_file_path

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment