QR Code for Guest WiFi

[sti0]

Hi there,
I'm coming straight from Home Assistant project because I implemented a camera entity for the fritz integration to display the guest wifi credentials as a QR code. This makes it possible to display the QR code e.g. on a tablet at the wall which runs HA.

For this case I used the existing FritzGuestWLAN class and it's functionality to get the password. It worked so far but the Home Assistant guidelines make it necessary to implement such a method in the underlying library which is fritzconnection in this case. So I closed my pull request (home-assistant/core#63112) and now I like to discuss if we could add this to the fritzconnection lib. It's necessary to add a dependency to generate the qr code (e.g. pyqrcode). Maybe we could add this as a extra requirement and if someone wants to use the QR code he must install fritzconnection[qr].

You could find the implementation of the QR code generation here.

What do you think about this?

BR
sti0

[kbr]

I've implemented a similar code a couple of months ago, because of another discussion (not here on github) how to provide a qr-code for a guest network. But then I decided against introducing this to fritzconnection.

One reason was that fritzconnection should be a library doing one thing – and this one thing right.

Another one was not to introduce an additional requirement not really necessary to get information about the router. Even if it would be an optional requirement it should be well maintained. As requests (a basic requirement of fritzconnection) can be considered as part of the python infrastructure, pyqrcode is an abandoned project. Also the follow up project pyqrcodeng is no longer maintained. And the mature and maintained qrcode needs optional requirements like pillow (a good library, but a no-go as a requirement for fritzconnection).

(There is another library segno that looks promising. May be I think a second time about this.)

But from my point of view, you have done everything right: combine several libraries to build something new. Working with data from devices should happen at application level. I'm not familiar with HA, but I can imagine use cases where data are collected from devices and presented in some special way, out of the scope of the devices providing the data. So I'm wondering that HA does not provide a way to do this.

I would suggest to inspect this first, because creating a qr-code in fritzconnection would just be a workaround for this more general problem.

[kbr]

I have had a second look at segno, preparing a protoype. The feature will make it to fritzconnection providing qr-codes for wlan access. I suppose this is also a typical use case.

[sti0]

Thank you @kbr .. That's great news :)

[kbr]

Hot of the press with version 1.9.0 - before time is running short ... :)