Increase code coverage

Author: Art4

tests/Unit/Client/NativeCurlClient/RequestTest.php

@@ -12,6 +12,7 @@
 /**
  * @covers \Redmine\Client\NativeCurlClient::request
  * @covers \Redmine\Client\NativeCurlClient::runRequest
+ * @covers \Redmine\Client\NativeCurlClient::createHttpHeader
  */
 class RequestTest extends TestCase
 {
@@ -68,6 +69,7 @@ public function testRequestReturnsCorrectResponse($method, $data, $statusCode, $
     public static function getRequestReponseData(): array
     {
         return [
+            ['GET', '', 101, '', ''],
             ['GET', '', 101, 'text/plain', ''],
             ['GET', '', 200, 'application/json', '{"foo_bar": 12345}'],
             ['GET', '', 301, 'application/json', ''],

tests/Unit/Client/Psr18Client/RequestTest.php

@@ -19,6 +19,7 @@
 /**
  * @covers \Redmine\Client\Psr18Client::request
  * @covers \Redmine\Client\Psr18Client::runRequest
+ * @covers \Redmine\Client\Psr18Client::createRequest
  */
 class RequestTest extends TestCase
 {
@@ -73,9 +74,10 @@ public function testRequestReturnsCorrectResponse($method, $data, $statusCode, $
     public static function getRequestReponseData(): array
     {
         return [
+            ['GET', '', 101, '', ''],
             ['GET', '', 101, 'text/plain', ''],
             ['GET', '', 200, 'application/json', '{"foo_bar": 12345}'],
-            ['GET', '', 301, 'application/json', ''],
+            ['GET', '', 301, 'application/xml', ''],
             ['GET', '', 404, 'application/json', '{"title": "404 Not Found"}'],
             ['GET', '', 500, 'text/plain', 'Internal Server Error'],
             ['POST', '{"foo":"bar"}', 101, 'text/plain', ''],

tests/Unit/Client/Psr18ClientTest.php

@@ -2,6 +2,7 @@
 
 namespace Redmine\Tests\Unit\Client;
 
+use Exception;
 use InvalidArgumentException;
 use PHPUnit\Framework\TestCase;
 use Psr\Http\Client\ClientInterface;
@@ -14,6 +15,7 @@
 use Redmine\Client\Client;
 use Redmine\Client\Psr18Client;
 use Redmine\Http\HttpClient;
+use stdClass;
 
 class Psr18ClientTest extends TestCase
 {
@@ -298,6 +300,23 @@ public static function getApiClassesProvider(): array
         ];
     }
 
+    /**
+     * @covers \Redmine\Client\Psr18Client::__construct
+     */
+    public function testCreateWithoutFactoryThrowsException()
+    {
+        $this->expectException(Exception::class);
+        $this->expectExceptionMessage('Redmine\Client\Psr18Client::__construct(): Argument #2 ($requestFactory) must be of type Psr\Http\Message\RequestFactoryInterface');
+
+        $client = new Psr18Client(
+            $this->createMock(ClientInterface::class),
+            new stdClass(),
+            $this->createMock(StreamFactoryInterface::class),
+            'http://test.local',
+            'access_token'
+        );
+    }
+
     /**
      * @covers \Redmine\Client\Psr18Client
      * @test