Fix bug in NativeCurlClient

Author: Art4

src/Redmine/Client/NativeCurlClient.php

@@ -102,31 +102,31 @@ public function stopImpersonateUser(): void
      */
     public function requestGet(string $path): bool
     {
-        return $this->runRequest('get', $path);
+        return $this->runRequest('GET', $path);
     }
 
     /**
      * Create and send a POST request.
      */
     public function requestPost(string $path, string $body): bool
     {
-        return $this->runRequest('post', $path, $body);
+        return $this->runRequest('POST', $path, $body);
     }
 
     /**
      * Create and send a PUT request.
      */
     public function requestPut(string $path, string $body): bool
     {
-        return $this->runRequest('put', $path, $body);
+        return $this->runRequest('PUT', $path, $body);
     }
 
     /**
      * Create and send a DELETE request.
      */
     public function requestDelete(string $path): bool
     {
-        return $this->runRequest('delete', $path);
+        return $this->runRequest('DELETE', $path);
     }
 
     /**
@@ -295,7 +295,7 @@ private function createCurl(string $method, string $path, string $body = '', str
         unset($curlOptions[CURLOPT_POST]);
         unset($curlOptions[CURLOPT_POSTFIELDS]);
         switch ($method) {
-            case 'post':
+            case 'POST':
                 $curlOptions[CURLOPT_POST] = 1;
                 if ($this->isUploadCall($path) && $this->isValidFilePath($body)) {
                     @trigger_error('Uploading an attachment by filepath is deprecated, use file_get_contents() to upload the file content instead.', E_USER_DEPRECATED);
@@ -311,13 +311,13 @@ private function createCurl(string $method, string $path, string $body = '', str
                     $curlOptions[CURLOPT_POSTFIELDS] = $body;
                 }
                 break;
-            case 'put':
+            case 'PUT':
                 $curlOptions[CURLOPT_CUSTOMREQUEST] = 'PUT';
                 if ($body !== '') {
                     $curlOptions[CURLOPT_POSTFIELDS] = $body;
                 }
                 break;
-            case 'delete':
+            case 'DELETE':
                 $curlOptions[CURLOPT_CUSTOMREQUEST] = 'DELETE';
                 break;
             default: // GET

tests/End2End/Group/GroupTest.php

@@ -29,11 +29,13 @@ public function testInteractionWithGroup(RedmineVersion $redmineVersion): void
             'name' => $groupName,
         ]);
 
-        $groupData = json_decode(json_encode($xmlData), true);
+        $jsonData = json_encode($xmlData);
 
-        $this->assertIsArray($groupData, json_encode($groupData));
-        $this->assertIsString($groupData['id']);
-        $this->assertSame($groupName, $groupData['name']);
+        $groupData = json_decode($jsonData, true);
+
+        $this->assertIsArray($groupData, $jsonData);
+        $this->assertIsString($groupData['id'], $jsonData);
+        $this->assertSame($groupName, $groupData['name'], $jsonData);
 
         $groupId = (int) $groupData['id'];