Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate AbstractApi::get(), AbstractApi::post(), AbstractApi::put() and AbstractApi::delete() #372

Closed
4 tasks done
Art4 opened this issue Feb 1, 2024 · 0 comments
Closed
4 tasks done
Assignees
Milestone

Comments

@Art4
Copy link
Collaborator

Art4 commented Feb 1, 2024

The methods AbstractApi::get(), AbstractApi::post(), AbstractApi::put() and AbstractApi::delete() are using AbstractApi::getContentTypeFromPath() to guess the content type from the path. It is preferable that the content type is provided directly by the methods in the API classes. This can be realized by using HttpClient::request() directly instead of using the method of AbstractApi. Therefore this methods could be deprecated.

@Art4 Art4 added this to the v2.6.0 milestone Feb 1, 2024
@Art4 Art4 self-assigned this Feb 14, 2024
@Art4 Art4 linked a pull request Feb 14, 2024 that will close this issue
@Art4 Art4 removed a link to a pull request Feb 14, 2024
@Art4 Art4 closed this as completed Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant