Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] atomic doesn't exist on mac, ios but is added #1019

Closed
hsdk123 opened this issue Jul 10, 2024 · 2 comments
Closed

[bug] atomic doesn't exist on mac, ios but is added #1019

hsdk123 opened this issue Jul 10, 2024 · 2 comments

Comments

@hsdk123
Copy link
Contributor

hsdk123 commented Jul 10, 2024

Problem line: https://github.com/kcat/openal-soft/blob/master/CMakeLists.txt#L206

Reference: nodejs/node#28232 (comment)

Is causing linker errors ex.

ld: library 'atomic' not found
clang: error: linker command failed with exit code 1 (use -v to see invocation)
@kcat
Copy link
Owner

kcat commented Jul 10, 2024

Sounds like a configuration issue. The code section you link to runs a check to see if -latomic can be linked when using atomic functions. If libatomic doesn't exist, that check should fail and not include it with the link. If it tries to link with libatomic later, that check must have succeeded.

This seems to have come up before with issue #760, with an iOS toolchain file having ENABLE_STRICT_TRY_COMPILE disabled that prevented the check from running and assuming success (the point of such checks is to see if they work; assuming something works when it may not is just asking for problems like that).

@hsdk123
Copy link
Contributor Author

hsdk123 commented Jul 10, 2024

it was the exact same toolchain! Thank you!

@hsdk123 hsdk123 closed this as completed Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants