forked from WebKit/WebKit
-
Notifications
You must be signed in to change notification settings - Fork 0
/
ChangeLog
11539 lines (7098 loc) · 384 KB
/
ChangeLog
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
2022-05-11 Yury Semikhatsky <yurys@chromium.org>
[WinCairo] Support file downloads
https://bugs.webkit.org/show_bug.cgi?id=240293
Reviewed by Fujii Hironori.
* Source/cmake/OptionsWin.cmake: enable DOWNLOAD_ATTRIBUTE by default in WinCairo.
2022-05-11 Jonathan Bedard <jbedard@apple.com>
Remove Subversion references from ReadMe
https://bugs.webkit.org/show_bug.cgi?id=240316
<rdar://problem/93127701>
Reviewed by Geoffrey Garen.
* ReadMe.md:
2022-05-06 Sihui Liu <sihui_liu@apple.com>
Unreviewed, add github info to contributors.json.
* metadata/contributors.json:
2022-05-09 Ryosuke Niwa <rniwa@webkit.org>
Introduction.md: Explain active DOM objects
https://bugs.webkit.org/show_bug.cgi?id=240212
Reviewed by Chris Dumez.
Added an elementary description of active DOM objects to Introduction.md.
* Introduction.md:
2022-05-08 Ryosuke Niwa <rniwa@webkit.org>
Introduction.md: Fix typos found by mcatanzaro
https://bugs.webkit.org/show_bug.cgi?id=240211
Reviewed by Tim Nguyen.
Fixed typos.
* Introduction.md:
2022-05-07 Ryosuke Niwa <rniwa@webkit.org>
Explain now node reference counting works in Introduction.md
https://bugs.webkit.org/show_bug.cgi?id=240202
Unreviewed. Fix an obvious typo.
* Introduction.md:
2022-05-07 Ryosuke Niwa <rniwa@webkit.org>
Explain now node reference counting works in Introduction.md
https://bugs.webkit.org/show_bug.cgi?id=240202
Reviewed by Chris Dumez.
Added explanation on how Node reference counting works.
* Introduction.md:
2022-05-06 Kate Cheney <katherine_cheney@apple.com>
Unreviewed, add github info to contributors.json.
* metadata/contributors.json:
2022-05-05 Per Arne Vollan <pvollan@apple.com>
Add GitHub user name
https://bugs.webkit.org/show_bug.cgi?id=240144
Unreviewed, add github user name to contributors.json.
* metadata/contributors.json:
2022-05-05 Megan Gardner <megan_gardner@apple.com>
Add github info for myself to contributors.json
https://bugs.webkit.org/show_bug.cgi?id=240140
Unreviewed metadata addition.
* metadata/contributors.json:
2022-05-02 Yijia Huang <yijia_huang@apple.com>
Update yijia's info in constributors
https://bugs.webkit.org/show_bug.cgi?id=239994
Unreviewed.
* metadata/contributors.json:
2022-04-30 Philippe Normand <philn@igalia.com>
[WPE][GTK] Enable MEDIA_SESSION by default
https://bugs.webkit.org/show_bug.cgi?id=239931
Reviewed by Michael Catanzaro.
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsWPE.cmake:
2022-04-29 Wenson Hsieh <wenson_hsieh@apple.com>
Unreviewed, add my GitHub account name to contributors.json
I also ran `validate-committer-lists --canonicalize` to fix up some minor style inconsistencies in this file
after some other recent additions.
* metadata/contributors.json:
2022-04-29 Diego Pino Garcia <dpino@igalia.com>
[GCC] std::remove_cvref is undefined in GCC8.4
https://bugs.webkit.org/show_bug.cgi?id=239881
Reviewed by Žan Doberšek.
r293505 changed the guard that added std::remove_cvref if not defined
by GCC, checking __cplusplus <= 201703L.
However in Ubuntu GCC8.4 this flag's value is 201709L. Thus, the
evaluation of this flag cannot reliably determine whether the compiler
has to define std::remove_cvref or not.
Instead of relying on a predefined compiler flag, what the patch does is
to attempt to compile a small snippet of code to check whether std::remove_cvref
is supported by the compiler. If successful, the flag 'HAVE_STD_REMOVE_CVREF' is defined.
* Source/cmake/OptionsCommon.cmake: Set and expose HAVE_STD_REMOVE_CVREF if needed.
* Source/cmake/WebKitCompilerFlags.cmake: Check whether GCC supports std::remove_cvref.
2022-04-28 Jer Noble <jer.noble@apple.com>
Unreviewed; add github account for Jer Noble to contributors.json.
* metadata/contributors.json:
2022-04-27 Jonathan Bedard <jbedard@apple.com>
[git-webkit] Run style checker
https://bugs.webkit.org/show_bug.cgi?id=239730
<rdar://problem/92428565>
Reviewed by Chris Dumez.
* metadata/git_config_extension: Add style-checker as pre-pr check.
2022-04-26 Michael Catanzaro <mcatanzaro@redhat.com>
Unreviewed, add my @redhat.com email
Since I switched from SVN -> GitHub I wound up committing using a different email address
than I had been using before. This wasn't intentional, but I like it, so whatever.
* metadata/contributors.json:
2022-04-26 Manuel Rego Casasnovas <rego@igalia.com>
Remove usage of makeWeakPtr() on Introduction.md
https://bugs.webkit.org/show_bug.cgi?id=239768
Reviewed by Chris Dumez.
* Introduction.md:
2022-04-24 Zan Dobersek <zdobersek@igalia.com>
[RISCV64] Enable Baseline JIT
https://bugs.webkit.org/show_bug.cgi?id=239708
Reviewed by Yusuke Suzuki.
Turn on the CMake defaults for ENABLE(JIT) and ENABLE(FTL_JIT) options
for RISCV64. These are enabled together to avoid having to worry about
a 64-bit platform that would want to allow compiling with Baseline JIT
enabled and FTL JIT disabled at the same time. But because FTL JIT
support for RISCV64 isn't complete yet, it's still disabled at runtime.
* Source/cmake/WebKitFeatures.cmake:
2022-04-22 Alex Christensen <achristensen@webkit.org>
Add my github account name
https://bugs.webkit.org/show_bug.cgi?id=239671
Reviewed by Chris Dumez.
* metadata/contributors.json:
2022-04-22 Chris Dumez <cdumez@apple.com>
Unreviewed, add Geoff's github username to contributors.json so he can review patches
* metadata/contributors.json:
2022-04-20 Yusuke Suzuki <ysuzuki@apple.com>
Unreviewed, add github accounts of Apple JSC reviewers
* metadata/contributors.json:
2022-04-19 Mark Lam <mark.lam@apple.com>
Update my GitHub login.
* metadata/contributors.json:
2022-04-19 Mark Lam <mark.lam@apple.com>
Adding my GitHub credentials.
* metadata/contributors.json:
2022-04-19 Karl Rackler <rackler@apple.com>
Coreection to botwatcher github username to contributors json
Reviewed by Jonathan Bedard.
* metadata/contributors.json:
2022-04-19 Dean Jackson <dino@apple.com>
Adding GitHub username.
* metadata/contributors.json:
2022-04-15 Justin Michaud <justin_michaud@apple.com>
[PGO] Fix build on intel machines
https://bugs.webkit.org/show_bug.cgi?id=239396
Reviewed by Jonathan Bedard.
We should use the correct comparison operator for Perl strings when checking
if we are building with PGO profile generation enabled.
2022-04-12 Jonathan Bedard <jbedard@apple.com>
[git-webkit] Allow projects to declare alternate remotes
https://bugs.webkit.org/show_bug.cgi?id=239261
<rdar://problem/91654752>
Reviewed by Dewei Zhu.
* metadata/git_config_extension: Add expected remotes.
2022-04-15 Justin Michaud <justin_michaud@apple.com>
Add GitHub info to contributors.json
https://bugs.webkit.org/show_bug.cgi?id=239410
Reviewed by Yusuke Suzuki.
* metadata/contributors.json:
2022-04-15 Saam Barati <sbarati@apple.com>
Unreviewed. Add my github into to contributors.json.
* metadata/contributors.json:
2022-04-14 Jonathan Bedard <jbedard@apple.com>
Add .github/pull_request_template.md
https://bugs.webkit.org/show_bug.cgi?id=239347
<rdar://problem/91763594>
Reviewed by Michael Catanzaro.
* .github/pull_request_template.md: Added.
2022-04-14 Justin Michaud <justin_michaud@apple.com>
[PGO] We should be able to build WebKit to collect PGO profiles easily
https://bugs.webkit.org/show_bug.cgi?id=238776
Reviewed by Wenson Hsieh.
* Makefile.shared:
* Source/cmake/WebKitFeatures.cmake:
2022-04-14 Zan Dobersek <zdobersek@igalia.com>
[GTK][WPE] Make the ENABLE_GPU_PROCESS CMake option depend on USE_ANGLE_WEBGL
https://bugs.webkit.org/show_bug.cgi?id=239330
Reviewed by Adrian Perez de Castro.
For the GTK and WPE ports, the ENABLE_GPU_PROCESS CMake option should
depend on the USE_ANGLE_WEBGL option being enabled. There's no plans
to support 'direct' GL execution in that process, and the ANGLE usage
also implies (for these two ports) usage of generic buffer solutions
that are shareable across process boundaries, as is necessary for a
functioning GPUProcess implementation.
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsWPE.cmake:
2022-04-13 Elliott Williams <emw@apple.com>
[Xcode] Fix public watchOS workspace build by updating scheme and build settings
https://bugs.webkit.org/show_bug.cgi?id=239301
Reviewed by Alexey Proskuryakov.
Add AD_HOC_CODE_SIGNING_ALLOWED=YES (similar to
https://commits.webkit.org/249449@main) and
DISABLE_SDK_METADATA_PARSING=YES in various places to work around
open-source workspace build failures when building for watchOS.
* WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:
- Remove libwebrtc from the "All Source" scheme. On watchOS, it doesn't
build, and on other platforms, it is an implicit dependency, so
removing it lets the build system determine whether or not it should
build.
- Remove MiniBrowser from the "All Source" scheme, as it's part of "All
Tools". "All Tools" probably shouldn't be built for embedded
platforms, as it contains some Mac-only tools, but we do not enforce
this.
2022-04-12 Elliott Williams <emw@apple.com>
Reland "[XCBuild] Enable dependency validation by default"
https://bugs.webkit.org/show_bug.cgi?id=238901
<rdar://problem/91379968>
Reviewed by Alexey Proskuryakov.
Addresses two problems that impacted the previous attempt at landing:
Derived Sources scripts which use generated xcfilelists contain
"optional" inputs which are only available in internal builds. These
inputs lead to spurious dependency validation errors. These scripts
are unique in that they run from script-only targets, not as a phase
in one of the project's native targets. So, in open-source builds,
restrict VALIDATE_DEPENDENCIES to only run on native targets.
When building an individual project, and not a workspace, it's
expected that many input dependencies in the build directory will be
missing from XCBuild's graph. Disable dependency validation unless we
_know_ we're building from a workspace, defined as when the
USE_WORKSPACE Make flag or --use-workspace build-webkit flag is
passed.
* Makefile.shared: Turn on validation errors when USE_WORKSPACE=YES.
Use a new build setting, WK_VALIDATE_DEPENDENCIES, which is the
"requested" validation level. The actual validation level set in
VALIDATE_DEPENDENCIES may be lower (see above).
2022-04-11 Zan Dobersek <zdobersek@igalia.com>
Unreviewed, removing one of my email addresses.
* metadata/contributors.json:
2022-04-09 Adrian Perez de Castro <aperez@igalia.com>
[GTK][WPE] Missing inter-module documentation links
https://bugs.webkit.org/show_bug.cgi?id=239016
Reviewed by Michael Catanzaro.
Add JS snippets to be used in the gi-docgen output to setup links to
other modules. Take advantage of being able to compute the documentation
API version suffix from the currently loaded page URL, which avoids having
a number of templates depending on the API version and having to deal with
the documentation API version being sometimes different than the actual API
version of the library. The URLs for GTK3 vs. GTK4 documentation cannot be
handled in the same way, and instead the JS snippet is also a template
expanded by CMake to allows using the ${GTK_API_VERSION} variable there.
* Source/cmake/FindGIDocgen.cmake: Add a new CONTENT_TEMPLATES option
to GI_DOCGEN(), which allows setting up files to be expanded as CMake
@ONLY templates and then be used as documentation content files.
2022-04-08 Elliott Williams <emw@apple.com>
Unreviewed, reverting r292591.
Causing spurious EWS errors
Reverted changeset:
"[XCBuild] Enable dependency validation by default"
https://bugs.webkit.org/show_bug.cgi?id=238901
https://commits.webkit.org/r292591
2022-04-07 Elliott Williams <emw@apple.com>
[XCBuild] Enable dependency validation by default
https://bugs.webkit.org/show_bug.cgi?id=238901
<rdar://problem/91379968>
Reviewed by Alexey Proskuryakov.
Set VALIDATE_DEPENDENCIES=YES_ERROR everywhere, so that builds fail
when task outputs are missing.
The only interesting detail is that we need to set an extended
attribute on the user's build directory in order for XCBuild to
validate dependencies _within_ that directory. Since a users' build
directory may not be created by XCBuild, have build-webkit and
set-webkit-configuration set the attribute manually.
* Makefile.shared: Remove the VALIDATE_DEPENDENCIES opt-in logic.
Always call through to set-webkit-configuration, because that's where
we verify that CreatedByBuildSystem is set on the build directory.
Don't pass -EnableBuildDebugging=1; it's not actually needed to enable
dependency validation.
2022-04-07 Martin Robinson <mrobinson@webkit.org>
[GTK] Turning on the address sanitizer should disable GIR and documentation
https://bugs.webkit.org/show_bug.cgi?id=238868
Reviewed by Adrian Perez de Castro.
* Source/cmake/OptionsGTK.cmake: Disable documentation when the address
sanitizer is on. Documentation depends on GIR. Also fix the adjustment
of the documentation setting when building on Mac. This also has to
happen before the call to find_package(GI).
2022-04-04 Stephan Szabo <stephan.szabo@sony.com>
[PlayStation] Re-disable WebDriver
https://bugs.webkit.org/show_bug.cgi?id=238756
Unreviewed build fix
* Source/cmake/OptionsPlayStation.cmake:
2022-04-04 Adrian Perez de Castro <aperez@igalia.com>
[WPE][GTK] REGRESSION(r292263): Cannot make release tarballs
https://bugs.webkit.org/show_bug.cgi?id=238698
Reviewed by Carlos Garcia Campos.
* Source/cmake/WebKitDist.cmake: Make "dist" and "distcheck" targets depend on "doc-all".
2022-04-04 Adrian Perez de Castro <aperez@igalia.com>
[CMake] Provide better messages when gi-docgen cannot be found
https://bugs.webkit.org/show_bug.cgi?id=238729
Reviewed by Carlos Garcia Campos.
When gi-docgen cannot be found, or cannot be executed, provide better error messages
than those provided by CMake. While at it, make the messages mention how gi-docgen
can be installed inside the WebKit source tree to be used for the build.
* Source/cmake/FindGIDocgen.cmake:
2022-04-04 Miguel Gomez <magomez@igalia.com>
Change contributor status of Miguel Gomez from committer to reviewer
https://bugs.webkit.org/show_bug.cgi?id=238730
Unreviewed.
* metadata/contributors.json:
2022-04-02 Adrian Perez de Castro <aperez@igalia.com>
[GTK] Replace gtk-doc with gi-docgen
https://bugs.webkit.org/show_bug.cgi?id=226662
Reviewed by Michael Catanzaro.
Import two new CMake modules which define commands to easy setup of GObject-Introspection
and gi-docgen. These in turn allow to remove a bunch of duplicated CMake code, reuse
the same for both the WPE and GTK ports, and remove the gnarly DocBook templates and
other auxiliary files previously used by gtk-doc (which amount to a sizeable amount of
code).
While at it, do a quick pass to fix the most egregious issues reported by gi-docgen's
linting mode and that all public symbols end up with at least some documentation in
the generated output. Follow-up patches will be needed to keep adapting to the style
encouraged by gi-docgen, fix linking between documented entities, make code examples
display properly, and a few other things.
* Source/PlatformGTK.cmake: Adapted to use the new CMake modules.
* Source/PlatformWPE.cmake: Ditto.
* Source/cmake/FindGI.cmake: Added.
* Source/cmake/FindGIDocgen.cmake: Added.
* Source/cmake/FindGObjectIntrospection.cmake: Removed.
* Source/cmake/OptionsGTK.cmake: Adapted to use the new CMake modules.
* Source/cmake/OptionsWPE.cmake: Ditto.
2022-04-01 Carlos Garcia Campos <cgarcia@igalia.com>
[GTK][WPE] Enable CSS Typed OM by default
https://bugs.webkit.org/show_bug.cgi?id=238659
Reviewed by Adrian Perez de Castro.
Always build with Typed OM enabled, it's handled by an off by default setting.
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsWPE.cmake:
2022-03-31 Don Olmstead <don.olmstead@sony.com>
[PlayStation] Enable more features by default
https://bugs.webkit.org/show_bug.cgi?id=238628
Reviewed by Fujii Hironori.
Move ENABLE_WEB_CRYPTO and add ENABLE_NETWORK_CACHE_SPECULATIVE_REVALIDATION
and ENABLE_NETWORK_CACHE_STALE_WHILE_REVALIDATE to the list of features on by default.
* Source/cmake/OptionsPlayStation.cmake:
2022-03-31 Don Olmstead <don.olmstead@sony.com>
[PlayStation] Enable WebDriver
https://bugs.webkit.org/show_bug.cgi?id=238615
Reviewed by Alex Christensen.
Enable WebDriver by default. Set values for input interactions.
* Source/cmake/OptionsPlayStation.cmake:
2022-03-30 Don Olmstead <don.olmstead@sony.com>
Turn DEVELOPER_MODE ON for all non-Apple ports in build-webkit
https://bugs.webkit.org/show_bug.cgi?id=238556
Reviewed by Alex Christensen.
Use DEVELOPER_MODE to determine what the defaults of ENABLE_API_TESTS and
ENABLE_MINIBROWSER should be. Make ENABLE_WEBKIT the default of ENABLE_MINIBROWSER.
* Source/cmake/OptionsPlayStation.cmake:
2022-03-29 Ryosuke Niwa <rniwa@webkit.org>
Add descriptions on how to start WPT and http test servers to Introduction.md
https://bugs.webkit.org/show_bug.cgi?id=238523
Reviewed by Chris Dumez.
* Introduction.md:
2022-03-29 Don Olmstead <don.olmstead@sony.com>
[LibWPE] Guard libxkbcommon code with WPE_ENABLE_XKB
https://bugs.webkit.org/show_bug.cgi?id=238510
Reviewed by Adrian Perez de Castro.
Post v1.12.0 introduces the WPE_ENABLE_XKB definition to libwpe. For v1.12.0 and earlier
the define is added to the WPE::libwpe target's compile options. For later versions the
pkg-config for the library will determine the presence of this definition.
* Source/cmake/FindWPE.cmake:
2022-03-26 Aakash Jain <aakash_jain@apple.com>
Update my github username.
Unreviewed.
* metadata/contributors.json:
2022-03-22 Per Arne Vollan <pvollan@apple.com>
REGRESSION(r291587): Unintentionally removed contributors change
https://bugs.webkit.org/show_bug.cgi?id=238204
Unreviewed, partial revert of r291587.
* metadata/contributors.json:
2022-03-22 Carlos Garcia Campos <cgarcia@igalia.com>
[GTK][WPE] Remove the ATK implementation
https://bugs.webkit.org/show_bug.cgi?id=238198
Reviewed by Adrian Perez de Castro.
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsWPE.cmake:
2022-03-21 Commit Queue <commit-queue@webkit.org>
Unreviewed, reverting r291055.
https://bugs.webkit.org/show_bug.cgi?id=238145
Invalid test expectations
Reverted changeset:
"[iOS] Hard link AVPictureInPictureController"
https://bugs.webkit.org/show_bug.cgi?id=237227
https://commits.webkit.org/r291055
2022-03-18 Philippe Normand <pnormand@igalia.com>
[GStreamer] Migrate gst-full support to 1.20
https://bugs.webkit.org/show_bug.cgi?id=237772
Reviewed by Xabier Rodriguez-Calvar.
* Source/cmake/GStreamerChecks.cmake:
2022-03-18 Philippe Normand <pnormand@igalia.com>
[GStreamer] Initial import of the GstWebRTC backend
https://bugs.webkit.org/show_bug.cgi?id=236540
Reviewed by Carlos Garcia Campos and Xabier Rodriguez-Calvar.
Enable GstWebRTC by default if a recent-enough (>= 1.20) version is available.
* Source/cmake/FindGStreamer.cmake:
* Source/cmake/GStreamerChecks.cmake:
* Source/cmake/GStreamerDefinitions.cmake:
* Source/cmake/GStreamerDependencies.cmake:
2022-03-18 Carlos Garcia Campos <cgarcia@igalia.com>
Add a public build option for PDF.js
https://bugs.webkit.org/show_bug.cgi?id=238023
Reviewed by Michael Catanzaro.
PDF.js increases the binary size of the library quite a bit, so embedders might want to disable it if they know
they don't need PDF support at all.
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsWPE.cmake:
* Source/cmake/WebKitFeatures.cmake:
2022-03-17 Zan Dobersek <zdobersek@igalia.com>
[GTK][WPE] Also enable USE_TEXTURE_MAPPER_DMABUF alongside other DMABuf-related defines
https://bugs.webkit.org/show_bug.cgi?id=238017
Reviewed by Alejandro G. Castro.
For the GTK port, define USE_TEXTURE_MAPPER_DMABUF alongside the
dependencies and defines for DMABuf-backed ANGLE integration. This will
enable usage of the DMABuf-based video sink in any GStreamer pipeline
and subsequently display of the provided DMABuf objects. A comment is
added to explain this should be covered by a separate configuration
option on which USE_ANGLE_WEBGL should then depend.
For the WPE port the define is also added but without conditions, just
like it's done for the dependencies and the USE_LIBGBM define.
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsWPE.cmake:
2022-03-17 Zan Dobersek <zdobersek@igalia.com>
[GTK][WPE] Guard libgbm and libdrm code, make them conditional dependencies for GTK
https://bugs.webkit.org/show_bug.cgi?id=237974
Reviewed by Alejandro G. Castro.
Guard usage of libgbm and libdrm dependencies with the USE_LIBGBM
define. This should be required until we can switch to a possibly more
dynamic implementation that doesn't require build-time dependencies.
For the GTK port, the desire is to keep these dependencies fully
optional. At the moment they are required when enabling ANGLE-backed
WebGL, with the USE_LIBGBM also defined in that case. This is needed
because ANGLE integration for Linux ports already depends on these
libraries.
For the WPE port only USE_LIBGBM is defined and the two dependencies
remain required.
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsWPE.cmake:
2022-03-14 Gabriel Nava Marino <gnavamarino@apple.com>
Add myself (Gabriel Nava Marino) to contributors.json
https://bugs.webkit.org/show_bug.cgi?id=237634
Unreviewed.
* metadata/contributors.json:
2022-03-11 Elliott Williams <emw@apple.com>
Makefile.shared: Rename WORKSPACE to WORKSPACE_PATH and allow overrides
https://bugs.webkit.org/show_bug.cgi?id=237746
Reviewed by Alexey Proskuryakov.
This permits Make-based workflows which build out of a different workspace, e.g. a workspace
that includes WebKitAdditions.
WORKSPACE_PATH was chosen as a new name for parity with SCRIPTS_PATH and to avoid confusion
with USE_WORKSPACE.
Refactors Makefile.shared a bit to prevent SCHEME or WORKSPACE_PATH being set without
USE_WORKSPACE from breaking the build.
* Makefile.shared:
2022-03-08 Jonathan Bedard <jbedard@apple.com>
[git-webkit] Support multiple metadata locations
https://bugs.webkit.org/show_bug.cgi?id=237395
<rdar://problem/89715863>
Reviewed by Dewei Zhu.
* metadata/git_config_extension: Renamed from metadata/project_config.
* metadata/project_config: Renamed to metadata/git_config_extension.
2022-03-10 Elliott Williams <emw@apple.com>
[XCBuild] Fix GeneratedSources dependency validation errors
https://bugs.webkit.org/show_bug.cgi?id=237490
Reviewed by Alexey Proskuryakov.
Fixes miscellanous targets which were not specifying their task outputs correctly.
For easier dependency validation testing, Make builds now recognize a VALIDATE_DEPENDENCIES
setting. Building with VALIDATE_DEPENDENCIES=YES or VALIDATE_DEPENDENCIES=YES_ERROR passes
the setting to xcodebuild and sets a magic xattr on the build directory so that product
files in it are validated.
* Makefile.shared:
2022-03-07 Basuke Suzuki <basuke.suzuki@sony.com>
Update Basuke Suzuki's status to reviewer
https://bugs.webkit.org/show_bug.cgi?id=237545
Unreviewed.
* metadata/contributors.json:
2022-03-07 Jonathan Bedard <jbedard@apple.com>
[webkitbugspy] Allow creation of new issues
https://bugs.webkit.org/show_bug.cgi?id=237123
<rdar://problem/89388181>
Reviewed by Dewei Zhu.
* metadata/trackers.json: Define project.
2022-03-03 Dan Glastonbury <djg@apple.com>
Add Dan Glastonbury's name to contributors.json
https://bugs.webkit.org/show_bug.cgi?id=237453
Reviewed by Alan Bujtas.
* metadata/contributors.json:
2022-03-03 Anjali Kumar <anjalik_22@apple.com>
Add myself (Anjali Kumar) to contributors.json
https://bugs.webkit.org/show_bug.cgi?id=237449
Reviewed by Patrick Angle.
* metadata/contributors.json: Added myself.
2022-03-01 Jonathan Bedard <jbedard@apple.com>
[git-webkit] Sync personal fork by default
https://bugs.webkit.org/show_bug.cgi?id=237324
<rdar://problem/89618617>
Reviewed by Dewei Zhu.
* metadata/project_config: Add webkitscmpy.update-fork option.
2022-03-02 Adrian Perez de Castro <aperez@igalia.com>
[CMake] Build failure with libstdc++ (>= 6) when cross-compiling (fatal error: stdlib.h: No such file or directory)
https://bugs.webkit.org/show_bug.cgi?id=161697
<rdar://problem/89613152>
Reviewed by Carlos Garcia Campos.
* Source/cmake/WebKitCompilerFlags.cmake: Go through CMake instead of the plain "env"
program for the sake of portability.
2022-03-01 Adrian Perez de Castro <aperez@igalia.com>
[CMake] Build failure with libstdc++ (>= 6) when cross-compiling (fatal error: stdlib.h: No such file or directory)
https://bugs.webkit.org/show_bug.cgi?id=161697
Reviewed by Carlos Garcia Campos.
* Source/cmake/WebKitCompilerFlags.cmake: Set LANG=C in compiler invocation to ensure its
output is consistent and the checks are independent from the system locale configuration.
2022-03-01 Basuke Suzuki <basuke.suzuki@sony.com>
[CMake] Disabling ENABLE_WEBCORE is ignored when cmake configuration runs again.
https://bugs.webkit.org/show_bug.cgi?id=237170
Reviewed by Fujii Hironori.
CMake variables which has chance to set from outside should be cached in CMake configuration cache.
Unless cacheing, the result of building the generated project is not consisitent because the other
configuration may run while building.
To make it complete, I've changed ENABLE_JAVASCRIPTCORE, ENABLE_WEBCORE and ENABLE_WEBKIT to `option()`
which is stored in cached and reused while building even if the confuguration runs again.
* Source/cmake/OptionsPlayStation.cmake:
* Source/cmake/WebKitCommon.cmake:
2022-02-28 Brandon Stewart <brandonstewart@apple.com>
Add Brandon Stewart's name to contributors.json
https://bugs.webkit.org/show_bug.cgi?id=237288
Reviewed by Saam Barati.
Add Brandon Stewart's name to contributors.json
* metadata/contributors.json:
2022-02-28 Michael Catanzaro <mcatanzaro@gnome.org>
-Wodr warning spam caused by ENABLE(BINDING_INTEGRITY)
https://bugs.webkit.org/show_bug.cgi?id=229867
<rdar://problem/82975115>
Reviewed by Carlos Garcia Campos.
Build WebKit with -Wno-odr. This warning is not salvagable, and it's impossible to suppress
locally.
* Source/cmake/WebKitCompilerFlags.cmake:
2022-02-24 Matt Woodrow <mattwoodrow@apple.com>
Unreviewed, update my (Matt Woodrow) status to committer.
* metadata/contributors.json:
2022-02-25 Zan Dobersek <zdobersek@igalia.com>
[GTK][WPE] Uncouple libgbm, libdrm dependencies from ANGLE functionality
https://bugs.webkit.org/show_bug.cgi?id=237199
Reviewed by Chris Lord.
For both GTK and WPE, unconditionally search for the libgbm and libdrm
dependencies as they will also be needed outside of ANGLE functionality.
USE_ANGLE is defined along with USE_NICOSIA, but still only if the
relevant option was enabled.
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsWPE.cmake:
2022-02-25 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. [GTK] Bump version numbers
* Source/cmake/OptionsGTK.cmake:
2022-02-24 Ryosuke Niwa <rniwa@webkit.org>
Explain visit children and opaque roots in Introduction.md
https://bugs.webkit.org/show_bug.cgi?id=236894
Reviewed by Saam Barati.
Added the descriptions of visit children and opaque roots
as well as how to add IDL files.
* Introduction.md:
2022-02-23 Elliott Williams <emw@apple.com>
[XCBuild] Don't automatically use the ../Internal/WebKit workspace
https://bugs.webkit.org/show_bug.cgi?id=237115
Reviewed by Alexey Proskuryakov.
When the USE_WORKSPACE=YES Make flag was added in https://commits.webkit.org/246232@main, we
configured Make to automatically use the workspace at ../Internal/WebKit/WebKit.xcworkspace,
if it was available. The idea was to make it easier for workspace builds to automatically
detect dependencies needed by folks at Apple, like WebKitAdditions.
In practice, this has made workspace builds silently rely on code from outside of the WebKit
repo, and it's unintuitive since non-workspace Make builds do not do this.
* Makefile.shared:
2022-02-23 W.D. Xiong <wdx@apple.com>
Add wdx's Github username to contributors.json
https://bugs.webkit.org/show_bug.cgi?id=237106
Unreviewed.
* metadata/contributors.json:
2022-02-23 Zan Dobersek <zdobersek@igalia.com>
[GStreamer] Add WebKitDMABufVideoSink
https://bugs.webkit.org/show_bug.cgi?id=236883
Reviewed by Philippe Normand.
* Source/cmake/FindGStreamer.cmake:
Also search for gstreamer-allocators-1.0, produce the relevant variables
containing include directories and cflags.
2022-02-22 Philippe Normand <pnormand@igalia.com>
[GStreamer] Initial MediaRecorder implementation
https://bugs.webkit.org/show_bug.cgi?id=236558
Reviewed by Xabier Rodriguez-Calvar.
Enable MediaRecorder support if GStreamer >= 1.20 is available.
* Source/cmake/FindGStreamer.cmake:
* Source/cmake/GStreamerChecks.cmake:
* Source/cmake/GStreamerDefinitions.cmake:
* Source/cmake/GStreamerDependencies.cmake:
2022-02-21 Carlos Garcia Campos <cgarcia@igalia.com>
[GTK][WPE] ANGLE: make USE_ANGLE_WEBGL build option public
https://bugs.webkit.org/show_bug.cgi?id=236962
Reviewed by Chris Lord.
Since it introduces new dependencies, the build option should be public and a fatal error message should be
shown when the option is enabled and any for the dependencies is missing.
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsWPE.cmake:
2022-02-20 Brandon Stewart <brandonstewart@apple.com>
Generate compile_commands.json on macOS Builds
https://bugs.webkit.org/show_bug.cgi?id=235686
Reviewed by Saam Barati.
Add support for generating compile_commands.json file to WebKit.
compile_commands.json can be used by tools like clangd to provide code complete,
refactoring, formatting, and cross references.
Steps to generate the compile commands file:
make d EXPORT_COMPILE_COMMANDS=YES
generate-compile-commands WebKitBuild/Debug
* Makefile.shared:
2022-02-19 Philippe Normand <pnormand@igalia.com>
[WPE][GTK] Enable Thunder and remove old Clearkey CDM/Decryptor
https://bugs.webkit.org/show_bug.cgi?id=235492
Reviewed by Xabier Rodriguez-Calvar.
Enable Thunder in developer builds, this is now needed for the clearkey EME layout tests.
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsWPE.cmake:
2022-02-18 Robert Jenner <Jenner@apple.com>
Unreviewed, reverting r290149.
Broke Debug Builds.
Reverted changeset:
"Generate compile_commands.json on macOS Builds"
https://bugs.webkit.org/show_bug.cgi?id=235686
https://commits.webkit.org/r290149
2022-02-18 Ryosuke Niwa <rniwa@webkit.org>
Replace trac URLs in Introduction.md by equivalent GitHub URLs
https://bugs.webkit.org/show_bug.cgi?id=236826