Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of opacityThreshold for USD Preview Surface #176

Open
ShantanuSriv opened this issue Sep 26, 2019 · 1 comment
Open

Addition of opacityThreshold for USD Preview Surface #176

ShantanuSriv opened this issue Sep 26, 2019 · 1 comment

Comments

@ShantanuSriv
Copy link

ShantanuSriv commented Sep 26, 2019

I think in the usd_material class we have not added opacityThreshold parameter which was introduced recently. It would be nice to have this feature included in the usd_material class because seems like this is performing the same operation as what alphaCutoff does in glTF.

USD Preview Surface - https://graphics.pixar.com/usd/docs/UsdPreviewSurface-Proposal.html

@danlee-lils
Copy link
Contributor

I have made this change. This change requires minor change in gltf material.py and making sure to add the opacityThreshold when blend mode is set to mask. Just a sidenote, Apple's quicklook at this point does not support opacityThreshold. Ping me and I can share it with you. One question that I would love to hear from kcoley is that I am not sure if I have to connect opacityThreshold to any kind of source... if you look at usd_material, opacity is connected to texture_shader source with 'a'. I am not sure if opacityThreshold needs a connection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants