Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RoundTripper should not add the /clusters/ segment if already present #44

Open
itdove opened this issue Jul 15, 2022 · 3 comments
Open

Comments

@itdove
Copy link
Contributor

itdove commented Jul 15, 2022

When dealing with multiple types of clients (controller-runtime, dynamic...) and also with the NewClusterAwareManager, it is easy to make the mistake to call the NewClusterConfig on the config used by the NewClusterAwareManaager.

The result is that the Roundtripper is registered twice and as being called twice the url contains the cluster workspace twice.

Logic must be added in the Roundtripper to avoid to add again the /clusters/ segment if already present.

@stevekuznetsov
Copy link
Contributor

@ncdc looks like this was not actually fixed in #45, right? This is what we hit today.

@ncdc
Copy link
Member

ncdc commented Aug 17, 2022

Partially fixed. Still has some edge cases

@ncdc
Copy link
Member

ncdc commented Aug 17, 2022

45 only checks for same cluster name and avoids adding it multiple times. What you & I hit today is 2 different paths.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants